Closed
Bug 1270173
Opened 8 years ago
Closed 8 years ago
Move protocol.js from devtools/server to devtools/shared.
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox49 fixed)
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: ejpbruel, Assigned: jfong)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jfong
:
review+
|
Details | Diff | Splinter Review |
To decouple the fronts from their actors, we also need remove all their dependencies on server code. Unfortunately, one such dependency is protocol.js itself. Since protocol.js is used by both the fronts and the actors, it should be moved to shared directory.
Updated•8 years ago
|
Whiteboard: [devtools-html] [triage]
Updated•8 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [devtools-html] [triage] → [devtools-html]
Assignee | ||
Comment 1•8 years ago
|
||
A really large patch but it's pretty straightforward. Not sure if I missed anything else in this fix, but let me know if this is correct.
Attachment #8749184 -
Flags: feedback?(ejpbruel)
Assignee | ||
Comment 2•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eeeed7ad5475&selectedJob=20371296
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8749184 [details] [diff] [review] Bug1270173.patch Review of attachment 8749184 [details] [diff] [review]: ----------------------------------------------------------------- Not much to review here. The important question is whether you forgot to update any requires. The best way to figure that out would be to simply run the tests. If you can get a green try run for the patch, it looks good to land to me.
Attachment #8749184 -
Flags: feedback?(ejpbruel) → feedback+
Assignee | ||
Comment 4•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7672195fb959
Attachment #8749184 -
Attachment is obsolete: true
Attachment #8749695 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a3d59df2a8e3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•8 years ago
|
Iteration: --- → 49.1 - May 9
Priority: P2 → P1
Depends on: 1271399
Updated•8 years ago
|
Whiteboard: [devtools-html]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•