From pref-cache.dtd: <!ENTITY diskCacheFolderExplanation "Cache files will be stored in a subfolder named &quot;Cache&quot; of the directory you specify. Restart Mozilla for changes to take effect."> Shouldn't "Mozilla" be "&brandShortName;" or something like that?

This should do it.

Comment on attachment 70780 [details] [diff] [review] patch r=bzbarsky

Removing bug 123569 from OtherBugsDependingOnThis since this bug is neither futured nor pushed out.

Comment on attachment 70780 [details] [diff] [review] patch sr=jag

a=brendan@mozilla.org for drivers in 0.9.9. /be

checked into trunk for 0.9.9.

Hmm... when I look at these two files, it doesn't look like the patch is applied: http://lxr.mozilla.org/mozilla/source/xpfe/components/prefwindow/resources/locale/en-US/pref-cache.dtd http://lxr.mozilla.org/mozilla/source/xpfe/components/prefwindow/resources/content/pref-cache.xul And according to these two, http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/components/prefwindow/resources/content&command=DIFF_FRAMESET&file=pref-cache.xul&rev1=1.50&rev2=1.51&root=/cvsroot http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpfe/components/prefwindow/resources/locale/en-US&command=DIFF_FRAMESET&file=pref-cache.dtd&rev1=1.17&rev2=1.18&root=/cvsroot your checkin did not cause any changes to the files.

Never mind my last comment. Now the last two URLs show the differences but the first two still show the original file. I guess it just takes some time for LXR and Bonsai to pick up the changes. (Whoohoo, one of my patches have been checked in! Finally... :-) )

Yeah, bonsai is usually 10 minutes to an hour behind, lxr is usually a few hours behind. :)