Closed Bug 1270406 Opened 9 years ago Closed 8 years ago

remove pseudo class :-moz-dir after :dir is shipped

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: bmo, Assigned: bmo)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(3 files)

Bug 1270406 - Unprefix pseudo-class dir in browser resources.
(deleted), text/x-review-board-request
adw
: review+
Details
Bug 1270406 - Unprefix pseudo-class dir in DevTool resources.
(deleted), text/x-review-board-request
pbro
: review+
Details
Bug 1270406 - Remove :-moz-dir support.
(deleted), text/x-review-board-request
xidorn
: review+
Details
Per bug 859301 comment 27, it's better to leave :-moz-dir() for a short transition period rather than removing it at exactly the same time as adding :dir. Open this bug to track the removal status.
Depends on: 859301
Blocks: unprefix
Can we do some research to see how widely used :-moz-dir() is (and if sites using it include an unprefixed fallback) before removing it?
Adding Blink and WebKit bugs to "See Also" field
See Also: → https://bugs.chromium.org/p/chromium/issues/detail?id=576815, https://bugs.webkit.org/show_bug.cgi?id=64861
I don't really believe this is widely-used currently. And even if it is, given that neither WebKit/Blink nor IE/Edge support it, I don't think removing the unprefixed version would break websites badly. I guess the best way to research this is to query the httparchive on the BigQuery. Hopefully they have CSS files included.
Assignee: nobody → aschen
Status: NEW → ASSIGNED
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=901949ce5bcfb9a737ff30dcb469a71d87fc1264 Unprefix version had been shipped on FF49, it's time to remove the support of prefix one from FF53. We will also take care of any webcompat issues jump out due to this change, and make the call whether or not worth doing it.
Attachment #8813207 - Flags: review?(adw)
Attachment #8813208 - Flags: review?(pbrosset)
Attachment #8813209 - Flags: review?(xidorn+moz)
Comment on attachment 8813209 [details] Bug 1270406 - Remove :-moz-dir support. https://reviewboard.mozilla.org/r/94716/#review95146
Attachment #8813209 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8813208 [details] Bug 1270406 - Unprefix pseudo-class dir in DevTool resources. https://reviewboard.mozilla.org/r/94714/#review95202
Attachment #8813208 - Flags: review?(pbrosset) → review+
Comment on attachment 8813207 [details] Bug 1270406 - Unprefix pseudo-class dir in browser resources. https://reviewboard.mozilla.org/r/94712/#review95404
Attachment #8813207 - Flags: review?(adw) → review+
Thanks for your review.
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96be179dc002 Unprefix pseudo-class dir in browser resources. r=adw https://hg.mozilla.org/integration/autoland/rev/71620574d3e5 Unprefix pseudo-class dir in DevTool resources. r=pbro https://hg.mozilla.org/integration/autoland/rev/1ba616d48ed7 Remove :-moz-dir support. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/96be179dc002 https://hg.mozilla.org/mozilla-central/rev/71620574d3e5 https://hg.mozilla.org/mozilla-central/rev/1ba616d48ed7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: