Closed
Bug 1270621
Opened 9 years ago
Closed 9 years ago
Remove remnants of MOZ_ETW
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: mshal, Assigned: mshal)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The configure variable to set MOZ_ETW was removed in bug 852676, but there are still a few checks for it in the build config. We can just delete these.
|
Assignee | |
Comment 1•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/50919/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/50919/
Attachment #8749380 -
Flags: review?(cmanchester)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8749380 [details]
MozReview Request: Bug 1270621 - Remove remnants of MOZ_ETW; r?chmanchester
https://reviewboard.mozilla.org/r/50919/#review47597
I also see js/src/devtools/ETWProvider.man in the tree but not referenced, we could probably ask sfink whether that's ok to remove as well.
Attachment #8749380 -
Flags: review?(cmanchester) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
:sfink, can we kill ETWProvider.man as well?
Flags: needinfo?(sphink)
|
||
Comment 4•9 years ago
|
||
(In reply to Michael Shal [:mshal] from comment #3)
> :sfink, can we kill ETWProvider.man as well?
Yes. I don't think anyone's used that stuff in years.
Flags: needinfo?(sphink)
|
|
Assignee | |
Comment 5•9 years ago
|
||
Comment on attachment 8749380 [details]
MozReview Request: Bug 1270621 - Remove remnants of MOZ_ETW; r?chmanchester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/50919/diff/1-2/
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8749380 -
Flags: review+ → review?(cmanchester)
|
|
||
Comment 6•9 years ago
|
||
Comment on attachment 8749380 [details]
MozReview Request: Bug 1270621 - Remove remnants of MOZ_ETW; r?chmanchester
https://reviewboard.mozilla.org/r/50919/#review48139
Attachment #8749380 -
Flags: review?(cmanchester) → review+
|
||
Comment 8•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
|
||
Updated•8 years ago
|
Blocks: nomakefiles
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•