Closed
Bug 1270718
Opened 9 years ago
Closed 8 years ago
[TV][Nexus Player] Option key cannot work
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Tracking
(blocking-b2g:2.6?)
RESOLVED
WONTFIX
blocking-b2g | 2.6? |
People
(Reporter: mlien, Unassigned)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
(deleted),
image/jpeg
|
Details |
[Testing Steps]
0. Power on Nexus Player
1. Focus on any card/deck
2. Press option key
[Expected result]
Enable to invoke option menu
[Actual result]
No any function
[Build Info]
Environment: Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/18fc4607ca127805586803e9300927ae257f725a
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344
Comment 1•9 years ago
|
||
@SC, do we map option key event to contextmenu event in Gecko?
Flags: needinfo?(schien)
Updated•9 years ago
|
blocking-b2g: 2.6? → 2.6+
Comment 2•9 years ago
|
||
@mlien, which button you press as option key? I don't see any button on nexus player mapped as option key so I'm confused.
Flags: needinfo?(schien) → needinfo?(mlien)
Comment 4•9 years ago
|
||
(In reply to Mike Lien[:mlien] from comment #3)
> I used "Shift+F10" as option key.
Sorry, on what OS? Since key mapping is OS dependent.
Flags: needinfo?(mlien)
Comment 5•9 years ago
|
||
set back to 2.6? because the root cause is unclear.
blocking-b2g: 2.6+ → 2.6?
Comment 6•9 years ago
|
||
(In reply to Evelyn Hung [:evelyn] from comment #4)
> (In reply to Mike Lien[:mlien] from comment #3)
> > I used "Shift+F10" as option key.
>
> Sorry, on what OS? Since key mapping is OS dependent.
oh... I was thinking it wrong by assuming you are on simulator. Sorry.
You are using hardware keyboard connecting to a Nexus player.
I don't think we map any key on HW keyboard as "Option" in lower layer...
Farmer, do you know this?
Flags: needinfo?(mlien) → needinfo?(fatseng)
Reporter | ||
Comment 7•9 years ago
|
||
Sorry for information lost, I really used simulator. :D
Reporter | ||
Comment 10•8 years ago
|
||
We didn't test this on real TV since real TV is not our reference device in 2.6. Refer to comment 2 this is because of lack of mapping key on Nexus Player
Flags: needinfo?(mlien)
Comment 11•8 years ago
|
||
Hi Joe,
Per our offline discussion, please make a decision about which button on Nexus Player Remote Control should be mapped to "Option" key for FxOS.
Thanks
Flags: needinfo?(jcheng)
Comment 12•8 years ago
|
||
We can pick one button on Nexus Player remote control and remap it to "MENU" key. This can be done by modifying https://github.com/mozilla-b2g/device-asus-fugu/blob/master/Nexus_Remote.kl. This will be automatically mapped to an UI key event 'ContextMenu' ( https://www.w3.org/TR/DOM-Level-3-Events-key/#keys-ui )
In Gaia, we can listen to 'ContextMenu' key event to trigger corresponding action, which will make us support 'App/Menu' key on windows keyboard as well.
Comment 14•8 years ago
|
||
Hi ShianYow,
Might find someone who can help before 7/15?
Thanks
Flags: needinfo?(swu)
Comment 15•8 years ago
|
||
I didn't see appropriate resource to help it in this time frame, let's put this bug into backlog, thanks.
Flags: needinfo?(swu)
Updated•8 years ago
|
blocking-b2g: 2.6? → ---
Comment 16•8 years ago
|
||
(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #12)
> We can pick one button on Nexus Player remote control and remap it to "MENU"
> key. This can be done by modifying
> https://github.com/mozilla-b2g/device-asus-fugu/blob/master/Nexus_Remote.kl.
> This will be automatically mapped to an UI key event 'ContextMenu' (
> https://www.w3.org/TR/DOM-Level-3-Events-key/#keys-ui )
I just tested to replace the keycode to MENU, and it displays keycode 93 on [1].
But I don't see anything changed on Gaia UI, so I'm not sure if it works.
[1] http://www.w3.org/2002/09/tests/keys.html
Comment 18•8 years ago
|
||
For now, we've realized that it's hard to be fixed from Gaia since it depends on Gecko's call flow a lot. S.C. is looking into it from Gecko's side and has some clues to the solution. However, as I know, it's a hard work, too.
S.C., Could you explain more? Thanks.
Flags: needinfo?(lchang) → needinfo?(schien)
Updated•8 years ago
|
blocking-b2g: --- → 2.6?
Comment 19•8 years ago
|
||
On Firefox desktop on GTK, widget layer will generate a ContextMenu event by itself when detecting MENU keypress. https://dxr.mozilla.org/mozilla-central/source/widget/gtk/nsWindow.cpp#3152
So, here is the updated suggestion:
In Gonk, we can pick one button on Nexus Player remote control and remap it to "MENU" key. This can be done by modifying https://github.com/mozilla-b2g/device-asus-fugu/blob/master/Nexus_Remote.kl. This will be automatically mapped to an UI key event 'ContextMenu' ( https://www.w3.org/TR/DOM-Level-3-Events-key/#keys-ui )
In Gecko, generate a contextmenu event when detecting MENU keypress.
No modification in Gaia.
Flags: needinfo?(schien)
Comment 20•8 years ago
|
||
Remote Control is out of 2.6 scope
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•