Thunderbird is the only application I know, that is including two application icons in its OS X desktop notification. The first one is the proper one and generated from aImageUrl in OSXNotificationCenter.mm. The second one is a leftover from former Growl times in Thunderbird and produced from kNewMailAlertIcon in nsMessengerOSXIntegration.mm. Let us remove the second one and fix the OS X notification style.

Comment on attachment 8750525 [details] [diff] [review] Patch Review of attachment 8750525 [details] [diff] [review]: ----------------------------------------------------------------- Someone who use a mac should check this. Aleth?

Comment on attachment 8750525 [details] [diff] [review] Patch Review of attachment 8750525 [details] [diff] [review]: ----------------------------------------------------------------- I don't use notifications, so I'm not the best person to review how this looks.

Should I do before and after screenshots?

That would help clarify the change, yes :-)

OK, hope this will better explain the change of the patch and what it is trying to fix. If we have removed the second icon we can als try to include a "Reply" button like in the notification of Mail, but this is another story than and a different bug.

Comment on attachment 8750525 [details] [diff] [review] Patch Review of attachment 8750525 [details] [diff] [review]: ----------------------------------------------------------------- OK, looks fine to me, thanks.