Closed
Bug 1271526
Opened 9 years ago
Closed 9 years ago
Drop CommonAnimationManager::ExtractComputedValueForTransition
Categories
(Core :: DOM: Animation, defect)
Core
DOM: Animation
Tracking
()
RESOLVED
DUPLICATE
of bug 1223658
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | affected |
People
(Reporter: birtles, Assigned: birtles)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
hiro
:
review+
|
Details | Diff | Splinter Review |
As of bug 1259285 this method is now pretty much empty. (We should have just removed it then.)
|
Assignee | |
Updated•9 years ago
|
Summary: Drop AnimationCommon::ExtractComputedValueForTransition → Drop CommonAnimationManager::ExtractComputedValueForTransition
|
|
Assignee | |
Comment 1•9 years ago
|
||
MozReview-Commit-ID: 2tQ5jjEkyxV
Attachment #8750606 -
Flags: review?(hiikezoe)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8750606 [details] [diff] [review]
Drop CommonAnimationManager::ExtractComputedValueForTransition
Review of attachment 8750606 [details] [diff] [review]:
-----------------------------------------------------------------
This is exactly what I have been done in part 1 for bug 1223658 in my patch queue locally.
You could also drop including StyleAnimationValue.h and nsCSSProperty.h from AnimationCommon.h.
Attachment #8750606 -
Flags: review?(hiikezoe) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> This is exactly what I have been done in part 1 for bug 1223658 in my patch
> queue locally.
>
> You could also drop including StyleAnimationValue.h and nsCSSProperty.h from
> AnimationCommon.h.
Oh, you should just land that then!
|
|
||
Comment 4•9 years ago
|
||
OK, once tree is open, I will land the patch soon. Leaving ni? to me here just in case.
Flags: needinfo?(hiikezoe)
|
|
||
Comment 5•9 years ago
|
||
Flags: needinfo?(hiikezoe)
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•