From bug 126714: ------- Additional Comment #11 From dbragg@netscape.com 2002-02-21 10:14 ------- I was going to log a separate bug for showing currently selected packs as that is a new "feature".

This should really get fixed before 1.0 (with a simple check icon) because it's currently really hard to see what is currently installed. The "old" dropdown box in Appearance panel had a notification like that.

low impact; correctness ->[adt3] seems to be fixed on 2002-05-10-1.0.0 ns build. need to verify.

Tao, the currently shown as "selected" entry in the listboxes don't nesessarily correspond to the actual applied language pack. Additionally, I think the selection of the entry is too little to be recognized as such. I think there such be something as a radio-button style icon, or a checkmark, for the currently applied pack.

ok. I agree that the UI needs improvement and this goes to theme as well.

After much testing and tracing I've determined that this IS working correctly. The selected language pack and content pack are highlighted. Granted there is no check mark or radio button but that's a much more involved feature as there is currently no widget like this available for a list box. There is a quirk though. A "default" content pack does not show up as selected because the pref is not in the all.js file. However, if you select the pack the next time you start up it will show selected. This is because the current code uses the pref value general.useragent.contentlocale to get the currently selected content pack. This pref is not in the all.js file. The strange thing is that when the pref is added to the all.js file you can't select a content pack into your profile's prefs.js. I'm checking with the prefs meister on this part.

Turns out the whole problem was that the default pref and value were not in navigator.properties where the language pack one is. I added the general.useragent.contentlocale pref to navigator.properties and added the url to navigator.properties to all.js.

Comment on attachment 86463 [details] [diff] [review] changes to netscape.properties and all.js r=tao

l10n approved.

Comment on attachment 86463 [details] [diff] [review] changes to netscape.properties and all.js sr=dveditz

Looking for adt approval for branch and trunk check-in. Adding adt1.0.1 keyword.

Moving adt1.0.1 keyword from Status Whiteboard to Keywords, so it gets on the ADT radar. ;-) jimmyu - can you verify this as fixed, once it has landed on the trunk. thanks!

new owner ->tao

adding adt1.0.1- per ADt.

-> jbetak, I will put this in to the trunk later today. I will also investigate some additional visual cue for the listbox.

requesting a= for Mozilla 1.1 trunk checkin

Comment on attachment 86463 [details] [diff] [review] changes to netscape.properties and all.js a=asa (on behalf of drivers) for checkin to 1.1

checked in - this should make it into Moz 1.1 and next Netscape release. Marking fixed.

man, how could we all look over this? Sorry, I have to reopen this bug. general.useragent.contentlocale shouldn't be in navigator.properties, it should be somewhere in the content pack, not the language pack. What we have in tree now would tell users they've selected a different content pack after changing thier language pack!

Kairo, you're obviously correct. I've overlooked the packaging issue as well when I landed dbragg's patch. I believe we should stick it into region.properties instead of navigator.properties. We need to get this into the Moz 1.1 release, patch coming up.

this places contentlocale pref in region.properties, which should be part of the content pack. Kairo, could you review this?

Comment on attachment 93618 [details] [diff] [review] corrected patch yes, this looks as it should be. r=kairo@kairo.at

thanks for catching this Kairo and for the review! Dan, could you put another sr=dveditz on this? Sorry for missing the packaging issue :-(

checked in. Kairo, could you please verify?

looks correct now. verified.