Closed Bug 1271579 Opened 9 years ago Closed 9 years ago

Integrate GtkTextDirection/GtkStateFlags to ClaimStyleContext

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: stransky, Unassigned)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

patch
(deleted), patch
karlt
: review+
Details | Diff | Splinter Review
patch for check-in
(deleted), patch
Details | Diff | Splinter Review
Follow up from Bug 1234158 comment 82 It implements GtkTextDirection/GtkStateFlags as a part of ClaimStyleContext
Attached patch patch (deleted) — — Splinter Review
I wonder if we need to set the GTK_STATE_FLAG_NORMAL state in ReleaseStyleContext(), as we do for menus when we don't call style save/restore. IMHO we don't need that because the GTK_STATE_FLAG_NORMAL state is automatically passed to ClaimStyleContext(). It may cause problems when the style for particular widget is get from both widget and ClaimStyleContext - but that's no our case.
Attachment #8750713 - Flags: review?(karlt)
Attachment #8750713 - Flags: review?(karlt) → review+
Attached patch patch for check-in (deleted) — — Splinter Review
https://hg.mozilla.org/mozilla-central/rev/3de4044b57f4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
No longer blocks: 1234158
Depends on: 1234158
Depends on: 1301194
Depends on: 1304850
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: