Closed
Bug 1271626
Opened 8 years ago
Closed 8 years ago
gUIStateBeforeReset has an erroneous property of gUIStateBeforeReset
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
https://hg.mozilla.org/mozilla-central/rev/1d1e647773f1 references a new property, deveditionTheme, on gUIStateBeforeReset. But when the gUIStateBeforeReset object is defined the new property is named gUIStateBeforeReset, not deveditionTheme. See line 2.30 in the diff above for the error, and line 2.48 for one of the references to the correct property name.
|
Assignee | |
Updated•8 years ago
|
Summary: gUIStateBeforeReset has a property of gUIStateBeforeReset when it should have been deveditionTheme → gUIStateBeforeReset has an erroneous property of gUIStateBeforeReset
|
|
Assignee | |
Comment 1•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1d1e647773f1 erroneously added it, then https://hg.mozilla.org/mozilla-central/rev/01482cdccd72 forgot to clean it up with the rest of the gUIStateBeforeReset changes.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attachment #8750775 -
Flags: review?(gijskruitbosch+bugs)
|
||
Updated•8 years ago
|
Attachment #8750775 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c21dcbe10ba0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in
before you can comment on or make changes to this bug.
Description
•