Closed
Bug 1271759
Opened 9 years ago
Closed 8 years ago
Detect and reject machines without SSE2
Categories
(Firefox :: Installer, defect)
Firefox
Installer
Tracking
()
RESOLVED
FIXED
Firefox 49
People
(Reporter: gps, Assigned: robert.strong.bugs)
References
Details
Attachments
(2 files, 3 obsolete files)
|
(deleted),
image/png
|
robert.strong.bugs
:
ui-review+
|
Details |
|
(deleted),
patch
|
robert.strong.bugs
:
review+
|
Details | Diff | Splinter Review |
Screenshot of error message
Firefox will be dropping support for running without SSE.
The installer should detect when the machine doesn't have SSE available and refuse to install.
bsmedberg: I /think/ this is the requirement you alluded to in email. Please chime in if I'm wrong.
|
||
Comment 1•8 years ago
|
||
Clarification: we plan on requiring SSE2.
Assignee: nobody → robert.strong.bugs
Summary: Detect and reject machines without SSE → Detect and reject machines without SSE2
|
Assignee | |
Comment 2•8 years ago
|
||
Attachment #8754600 -
Flags: ui-review?(shorlander)
|
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8754600 [details]
Screenshot of error message
So, the current string is
Sorry, $BrandShortName can't be installed. This version of $BrandShortName requires ${MinSupportedVer} or newer.
Where ${MinSupportedVer} is either
"Microsoft Windows XP SP2"
for x86 based systems or
"Microsoft Windows 7 x64"
for x64 based systems.
Note: ${MinSupportedVer} is defined in a non localized file which allows us to change it for all locales without updating the string in all locales.
Since the installer changes are needed for Firefox 49 we can go with a new string but I'd like to have the SSE part defined as we do for ${MinSupportedVer}.
|
|
Assignee | |
Comment 4•8 years ago
|
||
Matt, I'll submit a followup patch for the string changes and combine the patches into one before landing.
Attachment #8754636 -
Flags: review?(mhowell)
|
||
Updated•8 years ago
|
Attachment #8754636 -
Flags: review?(mhowell) → review+
|
||
Comment 5•8 years ago
|
||
Tracking for 49 as it is critical.
status-firefox49:
--- → affected
tracking-firefox49:
--- → blocking
|
|
Assignee | |
Comment 6•8 years ago
|
||
Attachment #8754600 -
Attachment is obsolete: true
Attachment #8754600 -
Flags: ui-review?(shorlander)
|
|
Assignee | |
Comment 7•8 years ago
|
||
Comment on attachment 8757074 [details]
Screenshots of messages
Note: I got approval of the strings, etc. from shorlander
Attachment #8757074 -
Flags: ui-review+
|
|
Assignee | |
Comment 8•8 years ago
|
||
Patch that applies on top of patch rev1. I'll attach a patch of the 2 combined as well.
I am going with the latest release system requirements page for now and when a link that redirects to the latest system requirements page for other channels is created I'll change the urls in a new bug.
Attachment #8757099 -
Flags: review?(mhowell)
|
|
Assignee | |
Comment 9•8 years ago
|
||
It might be easier to just review the combined patch.
Note: I'll remove the system requirements check in InstallOnInitCommon in another bug since it will require updating all apps that use InstallOnInitCommon.
|
|
Assignee | |
Updated•8 years ago
|
Component: NSIS Installer → Installer
Product: Toolkit → Firefox
|
|
Assignee | |
Comment 10•8 years ago
|
||
Note: bug 1276106 will add urls for beta and aurora but doesn't block this from landing. I'll file a new bug for changing the urls and bug 1276106 will block that bug.
|
|
||
Updated•8 years ago
|
Attachment #8757099 -
Flags: review?(mhowell) → review+
|
|
Assignee | |
Comment 12•8 years ago
|
||
Comment on attachment 8757100 [details] [diff] [review]
combined patch
Landed the combined patch
Attachment #8757100 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8757099 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8754636 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 13•8 years ago
|
||
|
||
Comment 14•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in
before you can comment on or make changes to this bug.
Description
•