Closed
Bug 1272189
Opened 8 years ago
Closed 8 years ago
Remove null-check of mTaskQueue from FFmpegDataDecoder<LIBAV_VER>::Shutdown()
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
INVALID
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Is it possible for |mTaskQueue| to be null?
Assignee | ||
Updated•8 years ago
|
Comment 1•8 years ago
|
||
(In reply to JW Wang [:jwwang] from comment #0)
> Is it possible for |mTaskQueue| to be null?
It used to, but I believe I've removed all the cases when I fixed bug 1212323. There may still be some gtest that do though.
like this:
https://hg.mozilla.org/releases/mozilla-release/file/tip/dom/media/fmp4/MP4Decoder.cpp#l209
Flags: needinfo?(jyavenard)
Assignee | ||
Comment 2•8 years ago
|
||
Seeing FFmpegDataDecoder<LIBAV_VER>::ProcessShutdown() is safe to be called on all threads, can we just call ProcessShutdown() in Shutdown() without additional dispatch?
https://dxr.mozilla.org/mozilla-central/source/dom/media/platforms/PlatformDecoderModule.h#205
"Shutdown() must block until the decoder has completed shutdown."
So it might be better to call ProcessShutdown() directly without dispatching for API conformance.
Comment 3•8 years ago
|
||
(In reply to JW Wang [:jwwang] from comment #2)
> Seeing FFmpegDataDecoder<LIBAV_VER>::ProcessShutdown() is safe to be called
> on all threads, can we just call ProcessShutdown() in Shutdown() without
> additional dispatch?
how so ?
the static monitor only ensure that not multiple decoder are shutting down ffmpeg at once (which isn't thread safe and cause various assert within ffmpeg).
I don't think it is safe to assume that the decoder is idle and finished prior shutdown being called.
Assignee | ||
Comment 4•8 years ago
|
||
You are right. I will close this bug as invalid.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•