Closed
Bug 1272225
Opened 8 years ago
Closed 8 years ago
Remove use of FlushableTaskQueue::Flush() from AppleATDecoder::Flush()
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: jwwang, Assigned: jwwang)
References
Details
Attachments
(3 files)
Similar to bug 1271517.
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/52365/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52365/
Attachment #8752009 -
Flags: review?(jyavenard)
Attachment #8752010 -
Flags: review?(jyavenard)
Attachment #8752011 -
Flags: review?(jyavenard)
Assignee | ||
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/52367/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52367/
Assignee | ||
Comment 3•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/52369/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52369/
Comment 4•8 years ago
|
||
Comment on attachment 8752009 [details]
MozReview Request: Bug 1272225. Part 1 - add assertions to make thread constraints clear. r=jya.
https://reviewboard.mozilla.org/r/52365/#review49389
Attachment #8752009 -
Flags: review?(jyavenard) → review+
Updated•8 years ago
|
Attachment #8752010 -
Flags: review?(jyavenard)
Comment 5•8 years ago
|
||
Comment on attachment 8752010 [details]
MozReview Request: Bug 1272225. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.
https://reviewboard.mozilla.org/r/52367/#review49391
::: dom/media/platforms/apple/AppleATDecoder.cpp:108
(Diff revision 1)
> +AppleATDecoder::Flush()
> +{
> + MOZ_ASSERT(mCallback->OnReaderTaskQueue());
> + LOG("Flushing AudioToolbox AAC decoder");
> + mIsFlushing = true;
> + nsresult rv = NS_OK;
theres nothing checking the return value of Flush(), you dont really need to worry about it.
could even make the API void while at it
Comment 6•8 years ago
|
||
Comment on attachment 8752010 [details]
MozReview Request: Bug 1272225. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.
https://reviewboard.mozilla.org/r/52367/#review49393
Attachment #8752010 -
Flags: review+
Comment 7•8 years ago
|
||
Comment on attachment 8752011 [details]
MozReview Request: Bug 1272225. Part 3 - remove use of FlushableTaskQueue. r=jya.
https://reviewboard.mozilla.org/r/52369/#review49395
Attachment #8752011 -
Flags: review?(jyavenard) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://reviewboard.mozilla.org/r/52367/#review49391
> theres nothing checking the return value of Flush(), you dont really need to worry about it.
>
> could even make the API void while at it
Making change to the API is huge. I will let it just return NS_OK for now. When all this is done, we will come back at reviewing the interfade of MediaDataDecoder.
Assignee | ||
Comment 9•8 years ago
|
||
Thanks for the review!
Comment 10•8 years ago
|
||
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0779a62475e2
https://hg.mozilla.org/mozilla-central/rev/d8df198bb552
https://hg.mozilla.org/mozilla-central/rev/f243def779e3
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•