We're sending CANCEL instead of ACTION when the button in the SimpleHelperUI is selected. (This is used for the readerview-bookmark-prompt, and will be used for further helper UIs soon.) http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java#119

I didn't pay attention while copying telemetry events. We send cancel when dismissing the prompt, action when the user selects the suggested prompt action. Review commit: https://reviewboard.mozilla.org/r/52241/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/52241/

Comment on attachment 8751836 [details] MozReview Request: Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian https://reviewboard.mozilla.org/r/52241/#review49455

https://hg.mozilla.org/integration/fx-team/rev/7084bd828e4c688daf6078a710d2f267bb52591a Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r=sebastian

Comment on attachment 8751836 [details] MozReview Request: Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian Approval Request Comment [Feature/regressing bug #]: Bug 1246238 [User impact if declined]: no user impact. UI telemetry contains incorrect action (cancel instead of action). This should be fixed in the next nightly, I'd prefer to update aurora (where this landed) for consistency when analysing UI telemetry. [Describe test coverage new/current, TreeHerder]: none (except manual local testing). [Risks and why]: Very low risk: different constant passed into call that sends UI telemetry from the reader view bookmark prompt. [String/UUID change made/needed]: none.

Comment on attachment 8751836 [details] MozReview Request: Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian Improve the telemetry data, taking it.