Closed
Bug 127269
Opened 23 years ago
Closed 21 years ago
unneeded null checks in attribute mapping / rule mapping functions
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.6alpha
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [patch])
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
There are lots of unneeded null checks in attribute mapping functions (and
struct mapping functions?), dating back to when hyatt was rewriting things and
they were only partly written. We should remove these (and make sure the caller
null checks the allocations before continuing).
|
Assignee | |
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla1.1beta
|
|
Assignee | |
Comment 2•23 years ago
|
||
In particular, I think all the null checks should be replaced by SID checks (if
the SID checks aren't already there). There's no need for null checks since
there's stack allocation, and SID checks mean we do less work.
Summary: unneeded null checks in attribute mapping functions → unneeded null checks in attribute mapping / rule mapping functions
|
|
Assignee | |
Updated•22 years ago
|
Target Milestone: mozilla1.1beta → mozilla1.2alpha
|
|
Assignee | |
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → Future
|
|
Assignee | |
Updated•22 years ago
|
Target Milestone: Future → mozilla1.5beta
|
|
Assignee | |
Comment 3•21 years ago
|
||
This contains the fix for this bug (which might let us move towards a
blob-allocation system for the rule data structs), plus a little cleanup in
nsHTMLTableCellElement (which includes an ordering fix for
WalkContentStyleRules -- more specific comes first, although the current code
doesn't have any conflicts), plus the patch for bug 214077, which I didn't want
to bother separating.
|
|
Assignee | |
Comment 4•21 years ago
|
||
|
|
Assignee | |
Updated•21 years ago
|
Attachment #129489 -
Flags: superreview?(bz-vacation)
Attachment #129489 -
Flags: review?(bz-vacation)
|
|
Assignee | |
Updated•21 years ago
|
Whiteboard: [patch]
Target Milestone: mozilla1.5beta → mozilla1.6alpha
|
||
Comment 5•21 years ago
|
||
Comment on attachment 129489 [details] [diff] [review]
patch (diff -uw, for review)
r+sr=bzbarsky
Attachment #129489 -
Flags: superreview?(bz-vacation)
Attachment #129489 -
Flags: superreview+
Attachment #129489 -
Flags: review?(bz-vacation)
Attachment #129489 -
Flags: review+
|
|
Assignee | |
Comment 6•21 years ago
|
||
Fix checked in to trunk, 2003-09-10 18:34 -0700.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•