Closed Bug 1273349 Opened 8 years ago Closed 8 years ago

Uplift libcubeb 2b3d6dc8 to aurora

Categories

(Core :: Audio/Video: cubeb, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox49 --- affected

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(1 file)

Filing a new bug, because there's not an obvious single bug that covers this already. We want the fix for bug 1269472 in aurora, and we've also fixed several other important libcubeb bugs (bug 1270135, bug 1270004, bug 1268675, bug 1268499, bug 1266623) in central that would be great to uplift. This tracks uplifting 2b3d6dc8 from upstream into aurora. central is already at 2b3d6dc8 and has been on this revision since May 6th, so I'm fairly confident this is a safe/good point to uplift.
Attached patch bug1273349_v0.patch (deleted) — Splinter Review
The changes have already been reviewed individually as they were made in central, so this request is more for general approval/rubber-stamping.
Attachment #8753139 - Flags: review?(rjesup)
Comment on attachment 8753139 [details] [diff] [review] bug1273349_v0.patch Approval Request Comment [Feature/regressing bug #]:1269472 1266623 1268499 1268675 1270135 [User impact if declined]: various audio capture bugs when using WebRTC/WebAudio [Describe test coverage new/current, TreeHerder]: fixes tested manually when made in central [Risks and why]: low risk, has been baking on central since May 6th [String/UUID change made/needed]: none
Attachment #8753139 - Flags: approval-mozilla-aurora?
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Comment on attachment 8753139 [details] [diff] [review] bug1273349_v0.patch After discussing this with jesup on IRC, we'll just cherry-pick the patch for bug 1269472 for now.
Attachment #8753139 - Flags: review?(rjesup)
Attachment #8753139 - Flags: approval-mozilla-aurora?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: