Mark Hammond [:markh] [:mhammond] Reporter
	Description • 8 years ago

Via bug 1268349:

The social-share-button is dynamically created and inserted into the toolbar the first time a social feature is used.  BrowserUITelemetry has a list of buttons that default to being in the toolbar so it can report items that are changed from the default.

Currently it lists the social-share-button as being a default in the navbar. This means that if telemetry is measured before the social features are activated, it will be reported in |defaultRemoved| (ie, that the user removed this button from the toolbar). If we change BrowserUITelemetry such that it is not considered as being in the navbar by default and telemetry was captured after the social features were enabled, it would start reporting it in |nondefaultAdded| - ie, that the user explicitly moved the item there.

We should try and fix this so measurements for that button become reliable.

	Mark Hammond [:markh] [:mhammond] Reporter
	Comment 1 • 8 years ago

FTR, https://hg.mozilla.org/mozilla-central/rev/7efca54b4920 landed a test browser_BrowserUITelemetry_defaults.js with a reference to this bug, and will need to be changed if this is fixed.

	:Gijs (he/him)
	Comment 2 • 7 years ago

I think after bug 1363485 it'll reported as nonDefaultAdded if the user does use social. Given the uncertain future of some of the social stuff, this seems like an excellent way of figuring out how many people actually use it. Should we just mark this WFM?

	Mark Hammond [:markh] [:mhammond] Reporter
	Comment 3 • 7 years ago

SGTM!