Closed Bug 1273397 Opened 8 years ago Closed 8 years ago

Remove use of FlushableTaskQueue::Flush() from VPXDecoder

Categories

(Core :: Audio/Video: Playback, defect, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla49
Tracking Flags:
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(5 files)

MozReview Request: Bug 1273397. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.
(deleted), text/x-review-board-request
jya
: review+
Details
MozReview Request: Bug 1273397. Part 2 - constify some members. r=jya.
(deleted), text/x-review-board-request
jya
: review+
Details
MozReview Request: Bug 1273397. Part 3 - remove use of FlushableTaskQueue::Flush(). r=jya.
(deleted), text/x-review-board-request
jya
: review+
Details
MozReview Request: Bug 1273397. Part 4 - remove use of FlushableTaskQueue. r=jya.
(deleted), text/x-review-board-request
jya
: review+
Details
MozReview Request: Bug 1273397. Part 5 - add assertions. r=jya.
(deleted), text/x-review-board-request
jya
: review+
Details
similar to bug 1273390.
Assignee: nobody → jwwang
Blocks: 1270039
Comment on attachment 8754914 [details] MozReview Request: Bug 1273397. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya. https://reviewboard.mozilla.org/r/54196/#review51148
Attachment #8754914 - Flags: review?(jyavenard) → review+
Comment on attachment 8754915 [details] MozReview Request: Bug 1273397. Part 2 - constify some members. r=jya. https://reviewboard.mozilla.org/r/54198/#review51150
Attachment #8754915 - Flags: review?(jyavenard) → review+
Comment on attachment 8754916 [details] MozReview Request: Bug 1273397. Part 3 - remove use of FlushableTaskQueue::Flush(). r=jya. https://reviewboard.mozilla.org/r/54200/#review51152
Attachment #8754916 - Flags: review?(jyavenard) → review+
Comment on attachment 8754917 [details] MozReview Request: Bug 1273397. Part 4 - remove use of FlushableTaskQueue. r=jya. https://reviewboard.mozilla.org/r/54202/#review51154
Attachment #8754917 - Flags: review?(jyavenard) → review+
Attachment #8754918 - Flags: review?(jyavenard) → review+
Comment on attachment 8754918 [details] MozReview Request: Bug 1273397. Part 5 - add assertions. r=jya. https://reviewboard.mozilla.org/r/54204/#review51156 ::: dom/media/platforms/agnostic/VPXDecoder.cpp:108 (Diff revision 1) > > int > VPXDecoder::DoDecode(MediaRawData* aSample) > { > + MOZ_ASSERT(mTaskQueue->IsCurrentThreadIn()); > + extra line, which is inconsistent with your other assertions.
Thanks for the review!
Comment on attachment 8754914 [details] MozReview Request: Bug 1273397. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54196/diff/1-2/
Comment on attachment 8754915 [details] MozReview Request: Bug 1273397. Part 2 - constify some members. r=jya. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54198/diff/1-2/
Comment on attachment 8754916 [details] MozReview Request: Bug 1273397. Part 3 - remove use of FlushableTaskQueue::Flush(). r=jya. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54200/diff/1-2/
Comment on attachment 8754917 [details] MozReview Request: Bug 1273397. Part 4 - remove use of FlushableTaskQueue. r=jya. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54202/diff/1-2/
Comment on attachment 8754918 [details] MozReview Request: Bug 1273397. Part 5 - add assertions. r=jya. Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54204/diff/1-2/
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: