STR: 1) Go to https://jakearchibald.github.io/svgomg/ 2) Open about:debugging 3) Click debug for the svgomg service worker script 4) Click the "{ }" button to pretty print the minified source Expected: prettified source Actual: a green progress bar that never finishes

Actually, this seems to happen when trying to pretty print normal worker scripts as well. Not just service workers.

Possibly related to bug 1271954. Eddy, I thought there already was a bug about pretty printing being broken for workers, but I couldn't find it. Please mark as duplicate if there actually was one.

I don't think we ever opened a bug for pretty printing in workers. Pretty printing requires source mapping, and the latter didn't even work in workers. Source mapping should work now, so it makes sense to open a bug for this now. In any case, I couldn't find a duplicate for this either, so let's keep this bug as is.

Can we at least disable the button on workers then? If you click this on a worker debugger you break that worker debugger display until the service worker is unregistered.

(In reply to Ben Kelly [:bkelly] from comment #4) > Can we at least disable the button on workers then? If you click this on a > worker debugger you break that worker debugger display until the service > worker is unregistered. Agreed.

(In reply to Jan Keromnes [:janx] from comment #5) > (In reply to Ben Kelly [:bkelly] from comment #4) > > Can we at least disable the button on workers then? If you click this on a > > worker debugger you break that worker debugger display until the service > > worker is unregistered. > > Agreed. That sounds good to me. James, would you be willing to look into this?

Sure, I'll have a patch in a few minutes

Comment on attachment 8765491 [details] [diff] [review] 1273730.patch Review of attachment 8765491 [details] [diff] [review]: ----------------------------------------------------------------- LGTM ::: devtools/client/debugger/content/views/sources-view.js @@ +109,5 @@ > > this._noResultsFoundToolTip = new Tooltip(document); > this._noResultsFoundToolTip.defaultPosition = FUNCTION_SEARCH_POPUP_POSITION; > > + if (Prefs.prettyPrintEnabled && !isWorker) { This needs a comment for why it is disabled if this is a worker. Could be as simple as pretty printing doesn't work in workers yet, so we've disabled this button for now.

Added comment. try is down right now, will commit later today

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=607a026ff791

Pushed by jlong@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/2256463545d7 remove pretty-print button if debugging workers because it doesn't work r=ejpbruel

I have reproduced this bug with Nightly 49.0a1 (2016-05-17) on Ubuntu 14.04, 64 bit! The bug's fix is now verified on latest Aurora 50.0a2. Aurora 50.0a2: Build ID 20160824004001 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0 [bugday-20160824]