Closed Bug 1273773 Opened 8 years ago Closed 8 years ago

[TV][Home] Add Folder button should use icon

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.6?)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.6?

People

(Reporter: Fischer, Assigned: jyeh)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(3 files)

icon_add folder_n.png
(deleted), image/png
Details
icon_add folder_s.png
(deleted), image/png
Details
[gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6
(deleted), text/x-github-pull-request
lchang
: review+
Details
Currently the Add Folder button is labeled by the "Add folder" text. Should change it to use icon instead of using text .
blocking-b2g: --- → 2.6?
No longer depends on: 1273428
Blocks: 1273776
No longer blocks: 1273776
Assignee: nobody → jyeh
Attached image icon_add folder_n.png (deleted) —
Attached image icon_add folder_s.png (deleted) —
Comment on attachment 8754228 [details] [gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6 Hi Luke, This patch will remove settings button and replace add folder button with icon. Please take a look, thanks!
Attachment #8754228 - Flags: review?(lchang)
Comment on attachment 8754228 [details] [gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6 Let's try to use "filter: invert(100%);" to do the transition on the icon. Also, please remove the handler of the setting button as well. Thanks.
Attachment #8754228 - Flags: review?(lchang)
Comment on attachment 8754228 [details] [gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6 Hi Luke, I've updated the patch, please take a look. Thanks!
Attachment #8754228 - Flags: review?(lchang)
Comment on attachment 8754228 [details] [gaia] jostw:josyeh/SmartHome/v2.6/Bug1273773 > mozilla-b2g:v2.6 Nice work!
Attachment #8754228 - Flags: review?(lchang) → review+
Landed in gaia v2.6 https://github.com/mozilla-b2g/gaia/commit/8e72a88a1513f22b57baf5163ec37f40f30a75e7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: