Closed
Bug 1273913
Opened 9 years ago
Closed 9 years ago
|CompositorBridgeParent::IsInCompositorThread| doesn't exist
Categories
(Core Graveyard :: Widget: Gonk, defect)
Core Graveyard
Widget: Gonk
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
This is a follow-up to bug 1273017.
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/53516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53516/
Assignee | ||
Comment 3•9 years ago
|
||
Comment on attachment 8753858 [details]
MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53516/diff/1-2/
Attachment #8753858 -
Attachment description: MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mwoodrow → MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow
Attachment #8753858 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #1)
> I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]
You don't. I have your patch applied and it doesn't fix the issue. And the linked attachment doesn't include the required changes.
Status: NEW → ASSIGNED
Comment 5•9 years ago
|
||
(In reply to Thomas Zimmermann [:tzimmermann] [:tdz] from comment #4)
> (In reply to Alexandre LISSY :gerard-majax from comment #1)
> > I already have it in bug 1273520 attachment 8753816 [details] [diff] [review]
>
> You don't. I have your patch applied and it doesn't fix the issue. And the
> linked attachment doesn't include the required changes.
Oh, looking at your patch, I see it's about MOZ_ASSERT(). I did an opt build, that might explain why. Hence, I'm wondering if you are not missing a couple of bits from what I have in this very same file, about the same kind of changes.
Comment 6•9 years ago
|
||
Oh no, it's another issue, I misread, sorry :)
Comment 7•9 years ago
|
||
Comment on attachment 8753858 [details]
MozReview Request: Bug 1273913: Call |CompositorThreadHolder::IsInCompositorThread| in Gonk screen manager, r?mattwoodrow
https://reviewboard.mozilla.org/r/53516/#review50446
Attachment #8753858 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•