Closed
Bug 1274274
Opened 8 years ago
Closed 8 years ago
Decouple element retrieval methods from ElementManager
Categories
(Remote Protocol :: Marionette, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
mozilla49
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
(Blocks 1 open bug)
Details
(Keywords: pi-marionette-server)
Attachments
(10 files, 1 obsolete file)
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
The element retrieval methods should be decoupled from the element.ElementManager class.
|
Assignee | |
Updated•8 years ago
|
Keywords: ateam-marionette-server
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•8 years ago
|
||
Moves element retrieval methods from ElementManager to the
testing/marionette/element.js module itself. This means some more
work needs to be done by the caller, but avoids bloat by ensuring
ElementManager does not end up as a super-object.
Review commit: https://reviewboard.mozilla.org/r/54282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54282/
Attachment #8754888 -
Flags: review?(dburns)
Attachment #8754889 -
Flags: review?(dburns)
Attachment #8754890 -
Flags: review?(dburns)
Attachment #8754891 -
Flags: review?(dburns)
Attachment #8754892 -
Flags: review?(dburns)
Attachment #8754893 -
Flags: review?(dburns)
Attachment #8754894 -
Flags: review?(dburns)
Attachment #8754895 -
Flags: review?(dburns)
Attachment #8754896 -
Flags: review?(dburns)
Attachment #8754897 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 2•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54284/
|
|
Assignee | |
Comment 3•8 years ago
|
||
Renames ElementManager to element.Store, exposing it on the
testing/marionette/element.js module. Shortens getKnownElement(uuid)
to get(uuid). Introduces new method has(uuid) to replace some unnecessary
checks in testing/marionette/driver.js and testing/marionette/listener.js.
Review commit: https://reviewboard.mozilla.org/r/54286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54286/
|
|
Assignee | |
Comment 4•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54288/
|
|
Assignee | |
Comment 5•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54290/
|
|
Assignee | |
Comment 6•8 years ago
|
||
Moved ElementManager#convertWrappedArguments to the
testing/marionette/element.js module scope and renamed it to fromJson.
Review commit: https://reviewboard.mozilla.org/r/54292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54292/
|
|
Assignee | |
Comment 7•8 years ago
|
||
Moves ElementManager#wrapValue to the testing/marionette/element.js
module level and renames it to toJson.
Review commit: https://reviewboard.mozilla.org/r/54294/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54294/
|
|
Assignee | |
Comment 8•8 years ago
|
||
Renames instances of `elementManager' to `seenEls' for brevity. Also the
word "manager" does not really explain what purpose it fulfills.
Review commit: https://reviewboard.mozilla.org/r/54296/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54296/
|
|
Assignee | |
Comment 9•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54298/
|
|
Assignee | |
Comment 10•8 years ago
|
||
This matches the Map data structure in JavaScript.
Review commit: https://reviewboard.mozilla.org/r/54300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54300/
|
|
Assignee | |
Comment 11•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/1-2/
|
|
Assignee | |
Comment 12•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/1-2/
|
|
Assignee | |
Comment 13•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/1-2/
|
|
Assignee | |
Comment 14•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/1-2/
|
|
Assignee | |
Comment 15•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/1-2/
|
|
Assignee | |
Comment 16•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/1-2/
|
|
Assignee | |
Comment 17•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/1-2/
|
|
Assignee | |
Comment 18•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/1-2/
|
|
Assignee | |
Comment 19•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/1-2/
|
|
Assignee | |
Comment 20•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/1-2/
|
|
Assignee | |
Comment 21•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/54572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54572/
Attachment #8755368 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 22•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/2-3/
|
|
Assignee | |
Comment 23•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/2-3/
|
|
Assignee | |
Comment 24•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/2-3/
|
|
Assignee | |
Comment 25•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/2-3/
|
|
Assignee | |
Comment 26•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/2-3/
|
|
Assignee | |
Comment 27•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/2-3/
|
|
Assignee | |
Comment 28•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/2-3/
|
|
Assignee | |
Comment 29•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/2-3/
|
|
Assignee | |
Comment 30•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/2-3/
|
|
Assignee | |
Comment 31•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/2-3/
|
|
Assignee | |
Comment 32•8 years ago
|
||
Addressed a problem where the arbitrary JSON objects to marshal were not returned. This caused a lot of tests to break.
|
||
Comment 33•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
https://reviewboard.mozilla.org/r/54282/#review51222
::: testing/marionette/driver.js:1680
(Diff revision 3)
> };
>
> switch (this.context) {
> case Context.CHROME:
> + if (!SUPPORTED_STRATEGIES.has(strategy)) {
> + throw new InvalidSelectorError("Strategy not supported: " + strategy);
Let's use templating here
::: testing/marionette/driver.js:1723
(Diff revision 3)
> };
>
> switch (this.context) {
> case Context.CHROME:
> + if (!SUPPORTED_STRATEGIES.has(strategy)) {
> + throw new InvalidSelectorError("Strategy not supported: " + strategy);
Lets use templating here
::: testing/marionette/element.js:607
(Diff revision 3)
>
> - case element.Strategy.ClassName:
> + case element.Strategy.ClassName:
> - return startNode.getElementsByClassName(value);
> + return startNode.getElementsByClassName(value);
>
> - case element.Strategy.TagName:
> + case element.Strategy.TagName:
> + logger.info("startNode=" + startNode);
debugging statement?
Attachment #8754888 -
Flags: review?(dburns) → review+
|
|
||
Comment 34•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
https://reviewboard.mozilla.org/r/54284/#review51226
Attachment #8754889 -
Flags: review?(dburns) → review+
|
|
||
Comment 35•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
https://reviewboard.mozilla.org/r/54286/#review51228
::: testing/marionette/element.js:162
(Diff revision 3)
> + * the DOM provided in the container.
> + */
> + get(uuid, container) {
> + let el = this.els[uuid];
> if (!el) {
> - throw new JavaScriptError(`Element has not been seen before. Id given was ${id}`);
> + throw new JavaScriptError("Element reference not seen before: " + uuid);
string template here
Attachment #8754890 -
Flags: review?(dburns) → review+
|
|
||
Updated•8 years ago
|
Attachment #8754891 -
Flags: review?(dburns) → review+
|
|
||
Comment 36•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
https://reviewboard.mozilla.org/r/54288/#review51234
|
|
||
Comment 37•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
https://reviewboard.mozilla.org/r/54290/#review51236
Attachment #8754892 -
Flags: review?(dburns) → review+
|
|
||
Comment 38•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
https://reviewboard.mozilla.org/r/54292/#review51238
::: testing/marionette/element.js:699
(Diff revision 3)
> + else if (Object.keys(obj).includes(element.Key) ||
> + Object.keys(obj).includes(element.LegacyKey)) {
> + let uuid = obj[element.Key] || obj[element.LegacyKey];
> + let el = this.get(uuid, {frame: win, shadowRoot: shadowRoot});
> + if (!el) {
> + throw new WebDriverError("Unknown element: " + uuid);
string templating
Attachment #8754893 -
Flags: review?(dburns) → review+
|
|
||
Comment 39•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
https://reviewboard.mozilla.org/r/54294/#review51240
Attachment #8754894 -
Flags: review?(dburns) → review+
|
|
||
Updated•8 years ago
|
Attachment #8754895 -
Flags: review?(dburns) → review+
|
|
||
Comment 40•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
https://reviewboard.mozilla.org/r/54296/#review51242
|
|
||
Comment 41•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
https://reviewboard.mozilla.org/r/54298/#review51244
Attachment #8754896 -
Flags: review?(dburns) → review+
|
|
||
Updated•8 years ago
|
Attachment #8754897 -
Flags: review?(dburns) → review+
|
|
||
Comment 42•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
https://reviewboard.mozilla.org/r/54300/#review51246
|
|
||
Comment 43•8 years ago
|
||
Comment on attachment 8755368 [details]
MozReview Request: Bug 1274274 - Remove debug statement in findElements; r?automatedtester
https://reviewboard.mozilla.org/r/54572/#review51248
This commit can be fixed in the first one so merge this to that commit
Attachment #8755368 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 44•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/3-4/
|
|
Assignee | |
Comment 45•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/3-4/
|
|
Assignee | |
Comment 46•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/3-4/
|
|
Assignee | |
Comment 47•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/3-4/
|
|
Assignee | |
Comment 48•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/3-4/
|
|
Assignee | |
Comment 49•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/3-4/
|
|
Assignee | |
Comment 50•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/3-4/
|
|
Assignee | |
Comment 51•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/3-4/
|
|
Assignee | |
Comment 52•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/3-4/
|
|
Assignee | |
Comment 53•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/3-4/
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8755368 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 54•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/4-5/
|
|
Assignee | |
Comment 55•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/4-5/
|
|
Assignee | |
Comment 56•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/4-5/
|
|
Assignee | |
Comment 57•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/4-5/
|
|
Assignee | |
Comment 58•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/4-5/
|
|
Assignee | |
Comment 59•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/4-5/
|
|
Assignee | |
Comment 60•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/4-5/
|
|
Assignee | |
Comment 61•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/4-5/
|
|
Assignee | |
Comment 62•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/4-5/
|
|
Assignee | |
Comment 63•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/4-5/
|
|
Assignee | |
Comment 64•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/5-6/
|
|
Assignee | |
Comment 65•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/5-6/
|
|
Assignee | |
Comment 66•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/5-6/
|
|
Assignee | |
Comment 67•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/5-6/
|
|
Assignee | |
Comment 68•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/5-6/
|
|
Assignee | |
Comment 69•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/5-6/
|
|
Assignee | |
Comment 70•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/5-6/
|
|
Assignee | |
Comment 71•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/5-6/
|
|
Assignee | |
Comment 72•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/5-6/
|
|
Assignee | |
Comment 73•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/5-6/
|
|
Assignee | |
Comment 74•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/6-7/
|
|
Assignee | |
Comment 75•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/6-7/
|
|
Assignee | |
Comment 76•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/6-7/
|
|
Assignee | |
Comment 77•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/6-7/
|
|
Assignee | |
Comment 78•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/6-7/
|
|
Assignee | |
Comment 79•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/6-7/
|
|
Assignee | |
Comment 80•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/6-7/
|
|
Assignee | |
Comment 81•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/7-8/
|
|
Assignee | |
Comment 82•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/7-8/
|
|
Assignee | |
Comment 83•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/7-8/
|
|
Assignee | |
Comment 84•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/7-8/
|
|
Assignee | |
Comment 85•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/7-8/
|
|
Assignee | |
Comment 86•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/6-7/
|
|
Assignee | |
Comment 87•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/6-7/
|
|
Assignee | |
Comment 88•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/6-7/
|
|
Assignee | |
Comment 89•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/7-8/
|
|
Assignee | |
Comment 90•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/7-8/
|
|
Assignee | |
Comment 91•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/8-9/
|
|
Assignee | |
Comment 92•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/8-9/
|
|
Assignee | |
Comment 93•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/8-9/
|
|
Assignee | |
Comment 94•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/8-9/
|
|
Assignee | |
Comment 95•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/8-9/
|
|
Assignee | |
Comment 96•8 years ago
|
||
Comment on attachment 8754888 [details]
MozReview Request: Bug 1274274 - Decouple element retrieval methods; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54282/diff/7-8/
|
|
Assignee | |
Comment 97•8 years ago
|
||
Comment on attachment 8754889 [details]
MozReview Request: Bug 1274274 - Convert ElementManager to a class; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54284/diff/7-8/
|
|
Assignee | |
Comment 98•8 years ago
|
||
Comment on attachment 8754890 [details]
MozReview Request: Bug 1274274 - Refactor seen element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54286/diff/7-8/
|
|
Assignee | |
Comment 99•8 years ago
|
||
Comment on attachment 8754891 [details]
MozReview Request: Bug 1274274 - Disassociate isDisconnected from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54288/diff/8-9/
|
|
Assignee | |
Comment 100•8 years ago
|
||
Comment on attachment 8754892 [details]
MozReview Request: Bug 1274274 - Remove unused method applyNamedArgs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54290/diff/8-9/
|
|
Assignee | |
Comment 101•8 years ago
|
||
Comment on attachment 8754893 [details]
MozReview Request: Bug 1274274 - Disassociate convertWrappedArguments from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54292/diff/9-10/
|
|
Assignee | |
Comment 102•8 years ago
|
||
Comment on attachment 8754894 [details]
MozReview Request: Bug 1274274 - Disassociate wrapValue from element store; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54294/diff/9-10/
|
|
Assignee | |
Comment 103•8 years ago
|
||
Comment on attachment 8754895 [details]
MozReview Request: Bug 1274274 - Rename element manager; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54296/diff/9-10/
|
|
Assignee | |
Comment 104•8 years ago
|
||
Comment on attachment 8754896 [details]
MozReview Request: Bug 1274274 - Update exported symbols and correct docs; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54298/diff/9-10/
|
|
Assignee | |
Comment 105•8 years ago
|
||
Comment on attachment 8754897 [details]
MozReview Request: Bug 1274274 - Rename element store clear function to delete; r?automatedtester
Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54300/diff/9-10/
|
||
Comment 106•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d585161b6b8
https://hg.mozilla.org/integration/mozilla-inbound/rev/02d31625ba14
https://hg.mozilla.org/integration/mozilla-inbound/rev/84c33f8de011
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d0cf052c1ce
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa348e14ae82
https://hg.mozilla.org/integration/mozilla-inbound/rev/e848faf4bb29
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd338221d470
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc85479726f9
https://hg.mozilla.org/integration/mozilla-inbound/rev/74c4d72ac0de
https://hg.mozilla.org/integration/mozilla-inbound/rev/769533c99dd8
|
||
Comment 107•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2d585161b6b8
https://hg.mozilla.org/mozilla-central/rev/02d31625ba14
https://hg.mozilla.org/mozilla-central/rev/84c33f8de011
https://hg.mozilla.org/mozilla-central/rev/7d0cf052c1ce
https://hg.mozilla.org/mozilla-central/rev/aa348e14ae82
https://hg.mozilla.org/mozilla-central/rev/e848faf4bb29
https://hg.mozilla.org/mozilla-central/rev/dd338221d470
https://hg.mozilla.org/mozilla-central/rev/dc85479726f9
https://hg.mozilla.org/mozilla-central/rev/74c4d72ac0de
https://hg.mozilla.org/mozilla-central/rev/769533c99dd8
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•