Closed
Bug 1274321
Opened 8 years ago
Closed 8 years ago
Add `req.expires()` to get cred expiration time
Categories
(Taskcluster :: Services, defect)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
References
Details
For bug 1267249, I'd like to generate temporary credentials in an API method, but I do not want that method to allow users to extend their existing credentials. So that API method needs to know when the caller's credentials expire.
This may also require augmentation of `auth.authenticateHawk`.
I see this as a companion to `req.clientId()`.
Assignee | ||
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/taskcluster-auth
https://github.com/taskcluster/taskcluster-auth/commit/60354d6beab622d2dfc2c16c1fe8c3b3532c91d3
Bug 1274321: return expires from authenticateHawk; r?jonasfj
https://github.com/taskcluster/taskcluster-auth/commit/5daa2a8a671e2156a91fe7b86cb57ddfba90958e
Merge djmitche/taskcluster-auth:bug1274321 (PR #66)
Assignee | ||
Comment 3•8 years ago
|
||
That's deployed without apparent adverse effect.
Next up is updating all of the clients to provide this data to the user.
Assignee | ||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/taskcluster-lib-api
https://github.com/taskcluster/taskcluster-lib-api/commit/cc00ce75b80775b6c3f3b356e8f108e96d3413ea
Bug 1274321: reflect the expiration time of credentials in req.expires
https://github.com/taskcluster/taskcluster-lib-api/commit/79420b9847ca225904df52bc3ab9db9329a07436
Merge pull request #36 from djmitche/bug1274321
Bug 1274321: reflect the expiration time of credentials in req.expires
Comment 6•8 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/taskcluster-lib-testing
https://github.com/taskcluster/taskcluster-lib-testing/commit/2a0ed856a9faf70617705affec36499be724ff56
Bug 1274321: return expires from fakeauth
https://github.com/taskcluster/taskcluster-lib-testing/commit/c3eda9108ed3147b6846be9187dc5b939d218386
Merge pull request #17 from djmitche/bug1274321
Bug 1274321: return expires from fakeauth
Assignee | ||
Comment 7•8 years ago
|
||
I was wrong about clients -- it's tc-lib-api (and for testing tc-lib-testing) that needed updating. Now done.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Platform Libraries → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•