Closed
Bug 1274374
Opened 9 years ago
Closed 8 years ago
add support for /update/6 URLs
Categories
(Release Engineering Graveyard :: Applications: Balrog (backend), defect)
Release Engineering Graveyard
Applications: Balrog (backend)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(3 files)
(deleted),
text/x-github-pull-request
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details |
(deleted),
text/x-github-pull-request
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details |
(deleted),
text/x-github-pull-request
|
nthomas
:
review+
bhearsum
:
checked-in+
|
Details |
These are being added for CPU features in https://bugzilla.mozilla.org/show_bug.cgi?id=1271761, we'll need support on the server before that lands.
Assignee | ||
Comment 1•9 years ago
|
||
Unlike other recent URL changes, this one will involve adding a new column to the database, too. The new URL is:
https://aus5.mozilla.org/update/4/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
The %SYSTEM_CAPABILITIES% section will currently have information about CPU features that the system supports, such as SSE or SSE2. In the future it may include other things. I suggest we treat this like OS_VERSION and do simple substring matches on it.
Comment 2•9 years ago
|
||
(In reply to Ben Hearsum (:bhearsum) from comment #1)
> Unlike other recent URL changes, this one will involve adding a new column
> to the database, too. The new URL is:
> https://aus5.mozilla.org/update/4/%PRODUCT%/%VERSION%/%BUILD_ID%/
> %BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/
> %DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
To avoid confusion, the path of this url should start /update/6 (to match the summary).
Assignee | ||
Comment 3•9 years ago
|
||
Details in the PR.
Assignee: nobody → bhearsum
Attachment #8754985 -
Flags: review?(nthomas)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8754986 -
Flags: review?(nthomas)
Updated•9 years ago
|
Attachment #8754986 -
Flags: review?(nthomas) → review+
Comment 5•9 years ago
|
||
Note regarding "Right now, it looks like it could be unknown, error, MMX, SSE, SSE2, or SSE3 based on my read of https://bug1271761.bmoattachments.org/attachment.cgi?id=8754952 "
It will be NA for platforms other than Windows until those platforms need values in this field.
Updated•9 years ago
|
Attachment #8754985 -
Flags: review?(nthomas) → review+
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/balrog
https://github.com/mozilla/balrog/commit/4219832bf5c94b5faa39ec4c4ce8daca8fbf6a35
bug 1274374: add support for /update/6 URLs (#84). r=nthomas
Assignee | ||
Updated•9 years ago
|
Attachment #8754986 -
Flags: checked-in+
Assignee | ||
Updated•9 years ago
|
Attachment #8754985 -
Flags: checked-in+
Assignee | ||
Comment 7•9 years ago
|
||
While testing this out in dev I realized that the way I implemented the matching (simple substring matching) means we can't just filter on "SSE" :(. I'm going to have to do a small follow-up that switches this to full string matching.
Assignee | ||
Comment 8•9 years ago
|
||
Nick, apologies for the follow-up here. I had the substring matching logic backwards in my head when I wrote the original patch =\.
Attachment #8757004 -
Flags: review?(nthomas)
Updated•8 years ago
|
Attachment #8757004 -
Flags: review?(nthomas) → review+
Assignee | ||
Updated•8 years ago
|
Attachment #8757004 -
Flags: checked-in+
Assignee | ||
Comment 9•8 years ago
|
||
rstrong and I verified this in dev, and I pushed to prod and reverified there. All done here.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Product: Release Engineering → Release Engineering Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•