Closed Bug 1274374 Opened 9 years ago Closed 8 years ago

add support for /update/6 URLs

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(3 files)

These are being added for CPU features in https://bugzilla.mozilla.org/show_bug.cgi?id=1271761, we'll need support on the server before that lands.
Unlike other recent URL changes, this one will involve adding a new column to the database, too. The new URL is: https://aus5.mozilla.org/update/4/%PRODUCT%/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml The %SYSTEM_CAPABILITIES% section will currently have information about CPU features that the system supports, such as SSE or SSE2. In the future it may include other things. I suggest we treat this like OS_VERSION and do simple substring matches on it.
(In reply to Ben Hearsum (:bhearsum) from comment #1) > Unlike other recent URL changes, this one will involve adding a new column > to the database, too. The new URL is: > https://aus5.mozilla.org/update/4/%PRODUCT%/%VERSION%/%BUILD_ID%/ > %BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%SYSTEM_CAPABILITIES%/ > %DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml To avoid confusion, the path of this url should start /update/6 (to match the summary).
Attached file add support for /update/6/ URLs (deleted) —
Details in the PR.
Assignee: nobody → bhearsum
Attachment #8754985 - Flags: review?(nthomas)
Attached file add UI to manage system capabilities (deleted) —
Attachment #8754986 - Flags: review?(nthomas)
Attachment #8754986 - Flags: review?(nthomas) → review+
Note regarding "Right now, it looks like it could be unknown, error, MMX, SSE, SSE2, or SSE3 based on my read of https://bug1271761.bmoattachments.org/attachment.cgi?id=8754952 " It will be NA for platforms other than Windows until those platforms need values in this field.
Attachment #8754985 - Flags: review?(nthomas) → review+
Attachment #8754986 - Flags: checked-in+
Attachment #8754985 - Flags: checked-in+
While testing this out in dev I realized that the way I implemented the matching (simple substring matching) means we can't just filter on "SSE" :(. I'm going to have to do a small follow-up that switches this to full string matching.
Attached file fix system capability matching (deleted) —
Nick, apologies for the follow-up here. I had the substring matching logic backwards in my head when I wrote the original patch =\.
Attachment #8757004 - Flags: review?(nthomas)
Attachment #8757004 - Flags: review?(nthomas) → review+
Attachment #8757004 - Flags: checked-in+
rstrong and I verified this in dev, and I pushed to prod and reverified there. All done here.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: