Open
Bug 1275493
Opened 8 years ago
Updated 4 years ago
[non-e10s] Do not update the combobox display text until the popup has been closed
Categories
(Core :: DOM: Core & HTML, defect, P5)
Tracking
()
NEW
People
(Reporter: jessica, Unassigned)
References
Details
Attachments
(1 file)
Updated•8 years ago
|
Blocks: platform-ui-team
From bug 1271532 comment 17, 18 and 19. In non-e10s <select>, to match the platform behavior in OS X and GTK, we should not update the combobox display text until the popup has been closed.
Updated•8 years ago
|
Summary: Do not update the combobox display text until the popup has been closed → [non-e10s] Do not update the combobox display text until the popup has been closed
Updated•8 years ago
|
tracking-e10s:
--- → -
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
Comment on attachment 8786509 [details] Bug 1275493 - Do not update <select> field while keying through items in dropdown with non-e10s on OS X and GTK. Seems to work ok, but it should be Mac and Linux specific.
Attachment #8786509 -
Flags: review?(enndeakin) → review-
Comment hidden (mozreview-request) |
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8786509 [details] Bug 1275493 - Do not update <select> field while keying through items in dropdown with non-e10s on OS X and GTK. https://reviewboard.mozilla.org/r/75432/#review73960
Attachment #8786509 -
Flags: review?(enndeakin) → review+
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75b2b455ddb1 Do not update <select> field while keying through items in dropdown with non-e10s on OS X and GTK. r=enndeakin+6102
Comment 6•8 years ago
|
||
Backed out for a11y selection failures e.g. in test_focus_selects.html: https://hg.mozilla.org/integration/autoland/rev/03204f6c0a7a48b27187e4207e733e2abae8d538 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=75b2b455ddb166711e0875817c2dd1d143887b26 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=2915454&repo=autoland 14:52:38 INFO - 180 INFO Invoke the 'current item change for 'list' ' test { scenario #0: un } 14:52:38 INFO - 181 INFO TEST-PASS | chrome://mochitests/content/a11y/accessible/tests/mochitest/events/test_focus_selects.html | Test with ID = 'current item change for 'list' ' succeed. There's no unexpected focus event. 14:52:38 INFO - 182 INFO Invoke the 'current item change for 'combobox' ' test { scenario #0: un } 14:52:38 INFO - 183 INFO TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/events/test_focus_selects.html | Error in test: proposed current item 'cb_apple' is already current 14:52:38 INFO - changeCurrentItem_reportError@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:1384:5 14:52:38 INFO - changeCurrentItem_invoke@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:1348:9 14:52:38 INFO - eventQueue_processNextInvoker@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:438:9 14:52:38 INFO - eventQueue/eventQueue_processNextInvokerInTimeout/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:463:42 14:52:38 INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:622:12 14:52:38 INFO - eventQueue_processNextInvokerInTimeout@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:463:5 14:52:38 INFO - eventQueue_processNextInvoker@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:445:7 14:52:38 INFO - eventQueue/eventQueue_processNextInvokerInTimeout/<@chrome://mochitests/content/a11y/accessible/tests/mochitest/events.js:458:43
Flags: needinfo?(mconley)
Comment 7•8 years ago
|
||
Thanks for the backout, will come back around to this when I get a chance.
Flags: needinfo?(mconley)
Comment 8•4 years ago
|
||
Bulk-downgrade of unassigned, 4 years untouched DOM/Storage bugs' priority.
If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.
Severity: normal → S4
Priority: P3 → P5
You need to log in
before you can comment on or make changes to this bug.
Description
•