Stephen Horlander [:shorlander] Reporter
	Description • 8 years ago

It looks like with the switch to GTK3 the Awesomebar and Search Pop-ups are inheriting the dark context menu appearance. They are really closer to combo boxes and dropdowns than context menus.

This dark appearance is ok for simple transient list like context menus. It's a little jarring for the complex UIs we have in these pops and it's popping up off of a generally light chrome toolbar and white field.

I mocked up a version that uses -moz-field and -moz-fieldtext that works around this. It's probably not semantically correct (-moz-combobox and -moz-comboboxtext might be) but it will likely give us a more consistent appearance across themes.

http://people.mozilla.org/~shorlander/awesomebar-results-colors/linux.html

	Dão Gottwald [:dao]
	Comment 2 • 8 years ago

(In reply to Stephen Horlander [:shorlander] from comment #0)
> It looks like with the switch to GTK3 the Awesomebar and Search Pop-ups are
> inheriting the dark context menu appearance. They are really closer to combo
> boxes and dropdowns than context menus.

Not just context menus, also main menu popups. I'm not really sure what the intent is on Ubuntu's side. It makes some sense for the main menus to be dark since they're attached to the dark title bar, but that's not true at all for context menus.

	Dão Gottwald [:dao]
	Comment 3 • 8 years ago

Basically I think -moz-appearance: menupopup; is overloaded now with gtk3 on Ubuntu.

	Stephen Horlander [:shorlander] Reporter
	Comment 4 • 8 years ago

(In reply to Dão Gottwald [:dao] from comment #2)
> (In reply to Stephen Horlander [:shorlander] from comment #0)
> > It looks like with the switch to GTK3 the Awesomebar and Search Pop-ups are
> > inheriting the dark context menu appearance. They are really closer to combo
> > boxes and dropdowns than context menus.
> 
> Not just context menus, also main menu popups. I'm not really sure what the
> intent is on Ubuntu's side. It makes some sense for the main menus to be
> dark since they're attached to the dark title bar, but that's not true at
> all for context menus.

While it's not how I would handle context menus, we are at least being consistent with the environment there: http://cl.ly/2n1x022o1J1K

	:Gijs (he/him)
	Comment 5 • 8 years ago

Bug 1268462 has effectively the same cause.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 6 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/60032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/60032/

	:Gijs (he/him)
	Comment 9 • 8 years ago

Shouldn't the foreground colors here be -moz-fieldtext instead of -moz-dialogtext, if we're using 'field' backgrounds for the panels?

	Dão Gottwald [:dao]
	Comment 10 • 8 years ago

Comment on attachment 8763917 [details]
Bug 1275700 - Fix the color of the AwesomeBar and Search Results popup on Linux.

Gijs is right. At a first glance it also looks like we should specify the color for .autocomplete-history-popup along with the background-color.

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 11 • 8 years ago

Comment on attachment 8763917 [details]
Bug 1275700 - Fix the color of the AwesomeBar and Search Results popup on Linux.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/60032/diff/1-2/

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 12 • 8 years ago

Comments addressed. I changed the color for .autocomplete-history-popup in the name of consistency, even though it didn't seem necessary in my testing.

	Dão Gottwald [:dao]
	Comment 13 • 8 years ago

Comment on attachment 8763917 [details]
Bug 1275700 - Fix the color of the AwesomeBar and Search Results popup on Linux.

> #PopupAutoCompleteRichResult > hbox[anonid="search-suggestions-notification"] {
>   border-bottom: 1px solid hsla(210, 4%, 10%, 0.14);
>   background-color: hsla(210, 4%, 10%, 0.07);
>+  color: -moz-FieldText;

color should automatically be inherited from the popup here, so you can just drop this line.

> .autocomplete-tree {
>   -moz-appearance: none !important;
>   border: none !important;
>   background-color: transparent !important;
>-  color: MenuText;
>+  color: -moz-FieldText;
> }

trees have color:-moz-fieldtext by default, so this shouldn't be needed. You could specify color:inherit to make this rock-solid, but then please update the windows and osx stylesheets as well.

> .autocomplete-richlistitem {
>-  color: MenuText;
>+  color: -moz-FieldText;
> }

ditto (richlistitems have color:-moz-fieldtext by default)

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 14 • 8 years ago

Thanks for the comments. I chose to simplify the linux stylesheet instead of updating all platforms to match.

	Pulsebot
	Comment 15 • 8 years ago

Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/9d3e753faf2b
Fix the color of the AwesomeBar and Search Results popup on Linux. r=dao

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 16 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/9d3e753faf2b

	Panos Astithas (he/him) [:past] (please ni?) Assignee
	Comment 17 • 8 years ago

Comment on attachment 8763917 [details]
Bug 1275700 - Fix the color of the AwesomeBar and Search Results popup on Linux.

Approval Request Comment
[Feature/regressing bug #]: the switch to GTK3
[User impact if declined]: on Ubuntu the awesomebar and search bar results will look bad
[Describe test coverage new/current, TreeHerder]: manual testing on Nightly
[Risks and why]: minor risk, these are Linux-specific and CSS-only changes
[String/UUID change made/needed]: none

	Gerry Chang [:gchang]
	Comment 18 • 8 years ago

Comment on attachment 8763917 [details]
Bug 1275700 - Fix the color of the AwesomeBar and Search Results popup on Linux.

This fixes a regression that the awesomebar and search bar results look bad on Ubuntu. Take it in 48 beta 4 and aurora.

	Carsten Book [:Tomcat]
	Comment 19 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/a9e1fd7149e0

	Carsten Book [:Tomcat]
	Comment 20 • 8 years ago

https://hg.mozilla.org/releases/mozilla-beta/rev/2605c36cc363

	Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact mboldan@mozilla.com
	Comment 21 • 8 years ago

I reproduced this bug using Fx 49.0a1, build ID:20160525030215 on Ubuntu 16.04 LTS.
Confirmed the fix on Fx 48.0b5, build ID  20160630123429; Fx 49.0a2, build ID  20160701004039;  and Fx 50.0a1, build ID 20160630030207.