Closed
Bug 1276152
Opened 8 years ago
Closed 8 years ago
bookmark validator should not consider "pos" element of a separator record
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: markh, Assigned: tcsc)
Details
Attachments
(1 file)
See bug 1228827 comment 4 - the tl;dr is that the "pos" value in a bookmark record is expected to be wrong in all sorts of cases, so we should ignore that in our comparisons.
Flags: firefox-backlog+
Assignee | ||
Comment 1•8 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/55826/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/55826/
Attachment #8757354 -
Flags: review?(markh)
Assignee | ||
Comment 2•8 years ago
|
||
I was running into issues with this with the TPS tests as well (hence bug 1274394 comment 11). I had assumed these were real bookmark sync bugs, but it's good to know they are not.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → tchiovoloni
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•8 years ago
|
||
(In reply to Thom Chiovoloni [:tcsc] from comment #2)
> I was running into issues with this with the TPS tests as well (hence bug
> 1274394 comment 11).
Yeah, I was confused by that comment - you didn't say what failures, but you already seemed to be handling some such errors - hence my comment 12 in that bug :) That bug doesn't mention "pos" at all.
Reporter | ||
Updated•8 years ago
|
Attachment #8757354 -
Flags: review?(markh) → review+
Reporter | ||
Comment 4•8 years ago
|
||
Comment on attachment 8757354 [details]
MozReview Request: Bug 1276152 - Ignore differences in the pos property when validating bookmark separators. r?markh
https://reviewboard.mozilla.org/r/55826/#review52762
Thanks!
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/6617e62776cd
Ignore differences in the pos property when validating bookmark separators. r=markh
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
You need to log in
before you can comment on or make changes to this bug.
Description
•