Closed
Bug 1276229
Opened 8 years ago
Closed 8 years ago
Reps: Move PropRep Component into its own module
Categories
(DevTools :: Shared Components, defect, P1)
DevTools
Shared Components
Tracking
(firefox49 fixed)
| Tracking | Status | |
|---|---|---|
| firefox49 | --- | fixed |
People
(Reporter: Honza, Assigned: Honza)
References
Details
(Whiteboard: [devtools-html])
Attachments
(1 file)
|
(deleted),
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
Both Grip() rep and Obj() rep define its own helper PropRep component. The component is located in the same file (grip.js/object.js)
We should move out PropRep() component into its own file/module so:
- We follow our rule: one component per file
- Grip() and Obj() reps can share it and we avoid code duplication.
Honza
|
Assignee | |
Comment 1•8 years ago
|
||
Ryan, just a small code clean up (mainly to avoid code duplication)
Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad2deb35365a
Honza
Component: Developer Tools → Developer Tools: Shared Components
Product: Developer Documentation → Firefox
Attachment #8758240 -
Flags: review?(jryans) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/fx-team/rev/78e2125dfb6b
Move PropRep Component into its own module; r=jryans
Keywords: checkin-needed
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [devtools-html]
|
||
Updated•8 years ago
|
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•