Closed
Bug 1276873
Opened 8 years ago
Closed 8 years ago
Intermittent browser_toolbox_window_title_frame_select.js | Test timed out -
Categories
(DevTools :: Framework, defect, P1)
DevTools
Framework
Tracking
(firefox49 fixed)
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: cbook, Assigned: Honza)
References
()
Details
(Keywords: intermittent-failure, Whiteboard: [btpp-fix-later] [devtools-html])
Attachments
(1 file)
(deleted),
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
https://treeherder.mozilla.org/logviewer.html#?job_id=9652635&repo=fx-team#L0-L3694
08:21:09 INFO - 124 INFO TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_window_title_frame_select.js | Test timed out -
Assignee | ||
Comment 1•8 years ago
|
||
Getting more info from try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=074b7921b4f4
Honza
Assignee: nobody → odvarko
Assignee | ||
Comment 2•8 years ago
|
||
Priority: -- → P1
Assignee | ||
Comment 3•8 years ago
|
||
Another try with more logging:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=608d3d98851b
Honza
Assignee | ||
Comment 4•8 years ago
|
||
Another try, complete log:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=95436e90a45f
Some failures:
https://treeherder.mozilla.org/#/jobs?repo=try&author=jdescottes@mozilla.com&selectedJob=21722438
Honza
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Blocks: devtools-html-2
Status: NEW → ASSIGNED
Iteration: --- → 49.3 - Jun 6
Flags: qe-verify-
Whiteboard: [btpp-fix-later] [devtools-html]
Comment hidden (Intermittent Failures Robot) |
Comment 7•8 years ago
|
||
Don't you just need to do:
let onOpen = once(menu, "open");
let menu = toolbox.showFramesMenu({target: btn});
yield onOpen;
instead of:
let menu = toolbox.showFramesMenu({target: btn});
yield once(menu, "open");
?
Assignee | ||
Comment 8•8 years ago
|
||
Patch + try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3b7954dde1f9
Honza
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Alexandre Poirot [:ochameau] from comment #7)
> Don't you just need to do:
> let onOpen = once(menu, "open");
> let menu = toolbox.showFramesMenu({target: btn});
> yield onOpen;
> instead of:
> let menu = toolbox.showFramesMenu({target: btn});
> yield once(menu, "open");
>
> ?
I tried to listen for the 'open' event immediately after the Menu is instantiated in showFramesMenu, but the event is never fired - instead I am getting 'popuphidden' (note that the issue happens only in the second test run).
I am not sure what really causes it, but using waitForTick() before trying to open the menu avoids the 'popuphidden' event and the menu opens just fine (like there was something happening on the current stack, e.g. a focus event?).
Honza
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8759146 [details] [diff] [review]
bug1276873.patch
Ryan, here is a patch that fixes the test failure (waitForTick). It also fixes the ways how 'items' in Menu object are accessed (using getter).
Honza
Attachment #8759146 -
Flags: review?(jryans)
Comment on attachment 8759146 [details] [diff] [review]
bug1276873.patch
Review of attachment 8759146 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/framework/test/browser_toolbox_window_title_frame_select.js
@@ +31,5 @@
> "Devtools title correct after switching to detached window host");
>
> + // Wait for tick to avoid unexpected 'popuphidden' event, which
> + // blocks the frame popup menu opened below. See also bug 1276873
> + yield waitForTick();
It's possible this is fragile on slow machines, but if it works for try it works for me.
Attachment #8759146 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 12•8 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #11)
> It's possible this is fragile on slow machines, but if it works for try it
> works for me.
Try is green, but I'll be watching it. This has been failing quite often
and we should see results soon.
Thanks for the review.
Honza
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment 14•8 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/f4fbac42bc5e
Wait for a tick to avoid unexpected popuphidden event; r=jryans
Keywords: checkin-needed
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Reporter | ||
Comment 18•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•