Closed
Bug 1276878
Opened 8 years ago
Closed 8 years ago
[Remote Control] Using input box to type password in browser sign-in page will show whole password
Categories
(Firefox OS Graveyard :: Gaia::TV, defect, P1)
Tracking
(blocking-b2g:2.6?)
RESOLVED
WONTFIX
blocking-b2g | 2.6? |
People
(Reporter: mlien, Assigned: chunmin)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
(deleted),
text/plain
|
Details |
[Testing Steps]
0. Paired Fennec and TV
1. Launch Browser app
2. Menu -> Sign-in to sync
3. Input e-mail -> Next
4. Typing password from input box of Fennec remote control
[Expected result]
Password should be protected
[Actual result]
Each character typing will show whole password for 2~3 seconds
[Build Info]
Environment: 2.6 Nexus Player
gaia:
https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
gecko:
https://github.com/mozilla-b2g/gecko-b2g/commit/1f9da1c47090cd29110df577ea1708cf6531c299
Reporter | ||
Updated•8 years ago
|
Component: GonkIntegration → Gaia::TV
Comment 1•8 years ago
|
||
Hi Luke, could you help to check can we improve this on current implementation?
Assignee: nobody → lchang
Comment 2•8 years ago
|
||
This issue is expectable since the string sent by remote control is like pasting the whole string from clipboard every time.
Hi Tim, do you know if these's any way to temporarily disable showing the last input in the password field?
Flags: needinfo?(timdream)
Comment 3•8 years ago
|
||
That's something burying deep in the editor/rendering code. After spending 10 min on dxr, blame points the implementation at bug 514212. Maybe you should try MOZ_GFX_OPTIMIZE_MOBILE build flag per patch there?
https://hg.mozilla.org/mozilla-central/rev/23e6d66d7d65
(That said, I can see MOZ_GFX_OPTIMIZE_MOBILE everywhere so you should probably not flip that...)
Flags: needinfo?(timdream)
Comment 4•8 years ago
|
||
Tim, Thanks a lot for your information.
Hi Eric,
According to Tim's comment, the password field's behavior is defined in Gecko. It seams there's no way to disable it temporarily through Gaia's implementation.
To fix this issue, I have two options:
1. Expose a Gecko API to enable/disable showing the last character in password fields.
2. Change the remote control client to send only the last character each time instead of sending entire strings. The cons are that it may be out of sync if users type characters on TV at the same time.
Any thought?
Flags: needinfo?(etsai)
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to Luke Chang [:lchang] from comment #4)
> 2. Change the remote control client to send only the last character each
> time instead of sending entire strings. The cons are that it may be out of
> sync if users type characters on TV at the same time.
Any changes in |handleRemoteTextInput|?
Assignee | ||
Comment 6•8 years ago
|
||
(In reply to Luke Chang [:lchang] from comment #4)
> The cons are that it may be out of sync if users type characters on TV at the same time.
From my test, if I type "cchang" in normal speed on Fennec, the TV will show something like "chg" only.
One edge case is that: there is already some text in the text-input field on TV's browser(may be typed by keyboard or something else) and there is empty in the text-input field of the Fennec side. From Fennec's perspective, if user type 'BACKSPACE', there is no thing change in text-input field, so Fennec may not do anything. Besides, Fennec can't receive the keyboard events, only can listen to the input events, so it needs to find other ways to get the user type 'BACKSPACE' on android's native keyboard(Do we have other events?).
If we have ASYNC text-input field between Fennec and TV, I think we should change the UI. The text-input field should be same as TV, or it will make users confused.
Personally I think we need to find out whether or not we should show the lastest character when we type the password on TV. If we don't need this feature, disabling it can be considered as a solution.
Assignee | ||
Comment 7•8 years ago
|
||
(In reply to Chun-Min Chang[:chunmin] from comment #6)
> Personally I think we need to find out whether or not we should show the
> lastest character when we type the password on TV. If we don't need this
> feature, disabling it can be considered as a solution.
Hi Joe, Josh, Tori
Could you give me some feedback about this?
Flags: needinfo?(tchen)
Flags: needinfo?(jocheng)
Flags: needinfo?(jcheng)
Comment 8•8 years ago
|
||
(In reply to Chun-Min Chang[:chunmin] from comment #7)
> Created attachment 8769549 [details]
> [WIP] Hide the latest character in password field
>
> (In reply to Chun-Min Chang[:chunmin] from comment #6)
> > Personally I think we need to find out whether or not we should show the
> > lastest character when we type the password on TV. If we don't need this
> > feature, disabling it can be considered as a solution.
> Hi Joe, Josh, Tori
> Could you give me some feedback about this?
If users can see password on their mobile screen, then I think it's ok not showing the latest character they just typed.
Also, I guess this change would not affect the interaction of typing with only the keyboard on TV?
Flags: needinfo?(tchen)
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Tori Chen [:tori] from comment #8)
> If users can see password on their mobile screen, then I think it's ok not
> showing the latest character they just typed.
> Also, I guess this change would not affect the interaction of typing with
> only the keyboard on TV?
Well, it will be applied to all the cases. The last character will be hidden in password field in all the cases no matter what the input source is.
If we need to hide the last character only when they are using remote controller, we might need to add some additional APIs to achieve it.
Assignee | ||
Updated•8 years ago
|
Blocks: TV_FxOS2.6
Comment 10•8 years ago
|
||
I assume user switches to remote control and type in remote control UI, so normal case is the input between TV and fennec should be the same. So I prefer to show any (or last) character on TV.
Flags: needinfo?(etsai)
Comment 11•8 years ago
|
||
Change assignee to Chun-Min since he is actually looking into it.
Assignee: lchang → cchang
Updated•8 years ago
|
Flags: needinfo?(jocheng)
Updated•8 years ago
|
Flags: needinfo?(jcheng)
Comment 12•8 years ago
|
||
Remote Control is out of 2.6 scope
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•