Closed
Bug 1277067
Opened 8 years ago
Closed 8 years ago
Remove nsIAsyncShutdown.contentChildShutdown
Categories
(Toolkit :: Async Tooling, defect)
Toolkit
Async Tooling
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
Yoric
:
review+
|
Details | Diff | Splinter Review |
Once the users of this are removed, then we should remove it so nobody starts using it. We want to avoid it because it slows down the shutdown of content processes in release builds.
We shouldn't forget to document in the idl and jsm why we're doing this. Otherwise, people will just re-add it.
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to David Rajchenbach-Teller [:Yoric] (please use "needinfo") from comment #1) > We shouldn't forget to document in the idl and jsm why we're doing this. > Otherwise, people will just re-add it. That sounds reasonable. It shouldn't be a long-term risk, because there is work underway to make the other user of content-child-shutdown, telemetry, not use it, whereupon it can be removed entirely.
Assignee | ||
Comment 3•8 years ago
|
||
try run (with patches for the other blocking bugs): https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbb7fd16bff0
Attachment #8758738 -
Flags: review?(dteller)
Attachment #8758738 -
Flags: review?(dteller) → review+
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/efcca7d36ad4 Remove nsIAsyncShutdown.contentChildShutdown. r=Yoric
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/efcca7d36ad4
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•