Closed
Bug 1277343
Opened 8 years ago
Closed 7 years ago
Add a task cluster task that builds rust-mozjs
Categories
(Core :: JavaScript Engine, defect, P2)
Core
JavaScript Engine
Tracking
()
RESOLVED
DUPLICATE
of bug 1277338
People
(Reporter: fitzgen, Unassigned)
References
Details
This will need to run rust-bindgen on JSAPI, build the sane Rust interface that wraps those generated definitions, build the rust-mozjs JS shell, and finally assert that this JS shell can successfully run js/src/Y.js. We should probably generate + build + test both opt and debug, since historically getting rust bindings to JSAPI on both opt and debug has been a bit of pain. This may also require getting rust-bindgen into tooltool or something. I expect further investigation will dig up new blockers.
Updated•8 years ago
|
Comment 1•8 years ago
|
||
My initial idea was to build rust-bindgen within this task, but that requires a nightly rustc, which I don't believe we have on tooltool. Perhaps a bindgen binary is indeed the best idea. Note that we need separate bindings per platform, due to C++ name mangling.
Comment 2•8 years ago
|
||
I agree that a binary should be all we need. We don't compile any other build tools such as clang, after all :)
> Note that we need separate bindings per platform, due to C++ name mangling.
It might be possible to generate these from one generated set of bindings. The mangling is predictable per-platform, at least. mwu thought we should be able to do this, at least.
The advantage would be that we could bundle them up in one go, which seems quite a bit simpler than creating them per-platform and then collecting them later.
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Iteration: --- → 50.1
Priority: P2 → P1
Updated•8 years ago
|
Assignee: nfitzgerald → nobody
Status: ASSIGNED → NEW
Iteration: 50.1 → ---
Priority: P1 → P2
Reporter | ||
Comment 3•8 years ago
|
||
Depends on https://github.com/servo/rust-bindgen/issues/16
Updated•8 years ago
|
Whiteboard: [devtools-html]
Reporter | ||
Comment 4•7 years ago
|
||
Doing this directly in bug 1277338.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•