Closed
Bug 1277354
Opened 8 years ago
Closed 8 years ago
TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_cache-control_request.js | xpcshell return code: 0 when not using cache2
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: jorgk-bmo, Assigned: aleth)
References
Details
(Keywords: intermittent-failure, Whiteboard: [necko-active])
Attachments
(1 file)
(deleted),
patch
|
mayhemer
:
review+
|
Details | Diff | Splinter Review |
First seen on C-C June 1st, 2016:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&selectedJob=38740
http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-win32/1464802135/comm-central_xp_ix_test-xpcshell-bm112-tests1-windows-build16.txt.gz
INFO - TEST-START | netwerk/test/unit/test_cache-control_request.js
WARNING - TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_cache-control_request.js | xpcshell return code: 0
INFO - TEST-INFO took 375ms
INFO - >>>>>>>
INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
INFO - (xpcshell/head.js) | test pending (2)
INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
INFO - running event loop
INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
INFO - netwerk/test/unit/test_cache-control_request.js | Starting
INFO - (xpcshell/head.js) | test pending (3)
INFO - (xpcshell/head.js) | test run_next_test 0 finished (3)
INFO - "CONSOLE_MESSAGE: (error) [JavaScript Error: "NS_ERROR_XPC_GS_RETURNED_FAILURE: Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]" {file: "resource://gre/modules/Webapps.jsm" line: 20}]"
INFO - TEST-PASS | netwerk/test/unit/test_cache-control_request.js | - 5 == 5
INFO - TEST-PASS | netwerk/test/unit/test_cache-control_request.js | - true == true
INFO - Error in closure function: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsICacheStorage.exists]" nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)" location: "JS frame :: C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/test_cache-control_request.js :: <TOP_LEVEL> :: line 107" data: no]
INFO - C:/slave/test/build/tests/xpcshell/tests/netwerk/test/unit/head_channels.js:ChannelListener.prototype.onStopRequest:172
INFO - C:\slave\test\build\tests\xpcshell\head.js:_do_main:209
INFO - C:\slave\test\build\tests\xpcshell\head.js:_execute_test:533
INFO - -e:null:1
INFO - exiting test
Assignee | ||
Updated•8 years ago
|
Comment 1•8 years ago
|
||
If this fails I presume it's a perma-failure? What could cause this:
- do_get_profile() doesn't actually create a profile for the xpc test
- the tree is somehow missing bug 1274585 which is a prerequisite to make this test work with exactly this error
This is a platform code test, running daily on m-c+ that, when hard to fix on c-c, can easily be just disabled on c-c.
Assignee | ||
Comment 2•8 years ago
|
||
mkmelin, is TB still not using cache2?
Flags: needinfo?(mkmelin+mozilla)
Comment 3•8 years ago
|
||
Unfortunately not using cache2 no, bug 1021843.
Flags: needinfo?(mkmelin+mozilla)
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to Magnus Melin from comment #3)
> Unfortunately not using cache2 no, bug 1021843.
Then the question is: is this the point where it becomes essential to make the switch?
I mean, we could disable this test, but does that just hide potential failures due to untested code paths?
Assignee | ||
Comment 5•8 years ago
|
||
(In reply to aleth [:aleth] from comment #4)
> I mean, we could disable this test, but does that just hide potential
> failures due to untested code paths?
Existing example for turning off the test:
https://dxr.mozilla.org/mozilla-central/source/netwerk/test/unit/test_bug651100.js#96
Reporter | ||
Comment 6•8 years ago
|
||
Note Bug 1241622 comment #2 (quote):
(Honza Bambas (:mayhemer))
> Note that soon (this year) we will remove cache v1 code altogether.
Comment 7•8 years ago
|
||
Ah!! yes, the test is using the new cache apis, right. Didn't realize that...
this is more a browser specific feature, I don't think when it breaks, TB will suffer from any serious bug.
Assignee | ||
Comment 8•8 years ago
|
||
OK, let's disable the test for now. But I don't have confidence it won't affect TB e.g. for people using the feed reader feature.
Attachment #8759172 -
Flags: review?(honzab.moz)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 9•8 years ago
|
||
Comment on attachment 8759172 [details] [diff] [review]
Disable test_cache-control_request when the old cache API is used
Review of attachment 8759172 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #8759172 -
Flags: review?(honzab.moz) → review+
Assignee | ||
Updated•8 years ago
|
Severity: major → normal
status-thunderbird49:
affected → ---
tracking-thunderbird49:
? → ---
Component: General → Networking: HTTP
Product: Thunderbird → Core
Assignee | ||
Comment 10•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/98d69e7bb6090115e70bd86234a92c3a313a5d1c
Bug 1277354 - Disable test_cache-control_request when the old cache API is used. r=mayhemer
Comment 11•8 years ago
|
||
Pushed by aleth@instantbird.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98d69e7bb609
Disable test_cache-control_request when the old cache API is used. r=mayhemer
Updated•8 years ago
|
Summary: TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_cache-control_request.js | xpcshell return code: 0 → TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_cache-control_request.js | xpcshell return code: 0 when not using cache2
Assignee | ||
Updated•8 years ago
|
Depends on: mail-cache2
Updated•8 years ago
|
Whiteboard: [necko-would-take]
Updated•8 years ago
|
Whiteboard: [necko-would-take] → [necko-active]
Comment 12•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in
before you can comment on or make changes to this bug.
Description
•