(Coverity static checker found this.) In mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp, |mIframeToDiv| may not be initialized properly all the time. Other member variables are properly initialized in case they may not be defined in the profile. We should do so for |mIframeToDiv|. (Actually, the initialization is not done when earlier exit is taken, but even then I wonder why |mIframeToDiv| is not handled as other variables are in the initialization code.) The patch follows.

I set |mIframeToDiv| to false which is the default value when it is not defined in profile. (Like I said this initialization does not happen if the early exit is taken a few lines above. We better be ready for such unusual case. "Safety first programming" is important.)

Comment on attachment 8759211 [details] [diff] [review] Set |mIframeToDiv| to false in class object initialization code. Review of attachment 8759211 [details] [diff] [review]: ----------------------------------------------------------------- Looks reasonable to me. You mean the member is not initialized when any of the NS_ENSURE_SUCCESS_VOID fire, because after the GetBoolPref() we always initialize it to something.