Closed
Bug 1277622
Opened 8 years ago
Closed 8 years ago
Use ActorClassWithSpec for the HeapSnapshotFileActor
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox49 fixed)
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ejpbruel
:
review+
|
Details | Diff | Splinter Review |
We don't have a HeapSnapshotFileFront, this actor is used under the covers in
the MemoryFront, but we should work towards all actors being defined in the
WithSpec way.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8759255 -
Flags: review?(ejpbruel)
Assignee | ||
Comment 2•8 years ago
|
||
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Assignee | ||
Updated•8 years ago
|
Whiteboard: [devtools-html]
Comment 3•8 years ago
|
||
Comment on attachment 8759255 [details] [diff] [review]
Use ActorClassWithSpec for the HeapSnapshotFileActor
Review of attachment 8759255 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/server/actors/heap-snapshot-file.js
@@ -64,5 @@
> yield bulk.copyFrom(stream);
> } finally {
> stream.close();
> }
> - }), {
There's no longer any need to wrap this method in a call to protocol.method() if it doesn't contain a request specification.
::: devtools/shared/specs/heap-snapshot-file.js
@@ +16,5 @@
> + }
> + },
> +});
> +
> +exports.heapSnapshotFileSpec = heapSnapshotFileSpec;
Thanks for not using default exports here. Personally, I find this much easier to read :-)
Attachment #8759255 -
Flags: review?(ejpbruel) → review+
Updated•8 years ago
|
Iteration: --- → 49.3 - Jun 6
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/2e7770dcd50e
Use ActorClassWithSpec for the HeapSnapshotFileActor; r=ejpbruel
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•8 years ago
|
Whiteboard: [devtools-html]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•