Closed
Bug 1277634
Opened 8 years ago
Closed 8 years ago
Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively
Categories
(DevTools :: General, defect, P1)
DevTools
General
Tracking
(firefox49 fixed)
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file, 2 obsolete files)
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8759272 -
Flags: review?(ejpbruel)
Assignee | ||
Comment 2•8 years ago
|
||
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=41572e412fe0
Updated•8 years ago
|
Flags: qe-verify-
Whiteboard: [devtools-html] → [devtools-html] [triage]
Assignee | ||
Updated•8 years ago
|
Attachment #8759272 -
Attachment is obsolete: true
Attachment #8759272 -
Flags: review?(ejpbruel)
Assignee | ||
Comment 4•8 years ago
|
||
New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=842b1323283a
Assignee | ||
Comment 5•8 years ago
|
||
Fix eslint errors due to moved code not previously eslinting. New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=eacaa169e92a
Attachment #8759332 -
Flags: review?(ejpbruel)
Assignee | ||
Updated•8 years ago
|
Attachment #8759307 -
Attachment is obsolete: true
Attachment #8759307 -
Flags: review?(ejpbruel)
Comment 6•8 years ago
|
||
Comment on attachment 8759332 [details] [diff] [review] Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively Review of attachment 8759332 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/server/actors/call-watcher.js @@ -156,5 @@ > name: name, > stack: stack, > timestamp: timestamp > }; > - }, { You no longer need the call to method() here.
Attachment #8759332 -
Flags: review?(ejpbruel) → review+
Updated•8 years ago
|
Iteration: --- → 49.3 - Jun 6
Priority: -- → P1
Whiteboard: [devtools-html] [triage] → [devtools-html]
Pushed by nfitzgerald@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/9ff998641a49 Decouple the CallWatcherFront and FunctionCallFront from the CallWatcherActor and FunctionCallActor respectively; r=ejpbruel
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ff998641a49
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•8 years ago
|
Whiteboard: [devtools-html]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•