Closed
Bug 1277705
Opened 8 years ago
Closed 8 years ago
Remove more Chromium IPC code
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: billm, Assigned: billm)
References
Details
(Whiteboard: btpp-active)
Attachments
(10 files)
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Lots of process-related stuff can be eliminated.
Assignee | ||
Comment 2•8 years ago
|
||
No one actually listens to these notifications.
Attachment #8759406 -
Flags: review?(dvander)
Assignee | ||
Comment 3•8 years ago
|
||
The purpose of all this code is to call OnWaitableEventSignaled at the right time. But all the implementations of these methods are no-ops.
Attachment #8759407 -
Flags: review?(dvander)
Assignee | ||
Comment 5•8 years ago
|
||
We only send messages on a channel, so this interface is pointless.
Attachment #8759409 -
Flags: review?(dvander)
Assignee | ||
Comment 6•8 years ago
|
||
No one uses this info.
Attachment #8759410 -
Flags: review?(dvander)
Assignee | ||
Comment 7•8 years ago
|
||
These are unused now that the notification service is gone.
Attachment #8759411 -
Flags: review?(dvander)
Assignee | ||
Comment 8•8 years ago
|
||
Attachment #8759412 -
Flags: review?(dvander)
Assignee | ||
Comment 9•8 years ago
|
||
Only one of these is ever used.
Attachment #8759413 -
Flags: review?(dvander)
Assignee | ||
Comment 10•8 years ago
|
||
More unused stuff here.
Attachment #8759414 -
Flags: review?(dvander)
Assignee | ||
Updated•8 years ago
|
Attachment #8759413 -
Attachment is patch: true
Attachment #8759404 -
Flags: review?(dvander) → review+
Attachment #8759406 -
Flags: review?(dvander) → review+
Attachment #8759407 -
Flags: review?(dvander) → review+
Comment on attachment 8759408 [details] [diff] [review]
remove child process host iterator
Review of attachment 8759408 [details] [diff] [review]:
-----------------------------------------------------------------
I was wondering what this was for.
Attachment #8759408 -
Flags: review?(dvander) → review+
Attachment #8759409 -
Flags: review?(dvander) → review+
Attachment #8759410 -
Flags: review?(dvander) → review+
Attachment #8759411 -
Flags: review?(dvander) → review+
Attachment #8759412 -
Flags: review?(dvander) → review+
Attachment #8759413 -
Flags: review?(dvander) → review+
Attachment #8759414 -
Flags: review?(dvander) → review+
Updated•8 years ago
|
Whiteboard: btpp-active
Comment 12•8 years ago
|
||
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29be71153ecc
Remove ChildProcessHost::InstanceCreated (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e87508415b2
Remove chromium notification service (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f7e0062d7f
Remove waitable_event_watcher (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/678e3b86d9ee
Remove child_process_host iter (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1d1ea36eb8e
Remove Message::Sender interface (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/47cb7a74ba07
Remove child_process_info (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/f39c77b470b8
Remove more notification-related files (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b6e2a714cec
Remove some child_process code (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fa404d3fde2
Remove result_codes (r=dvander)
https://hg.mozilla.org/integration/mozilla-inbound/rev/9bc9d14ce2df
Simplify child_thread (r=dvander)
Comment 13•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/29be71153ecc
https://hg.mozilla.org/mozilla-central/rev/6e87508415b2
https://hg.mozilla.org/mozilla-central/rev/28f7e0062d7f
https://hg.mozilla.org/mozilla-central/rev/678e3b86d9ee
https://hg.mozilla.org/mozilla-central/rev/a1d1ea36eb8e
https://hg.mozilla.org/mozilla-central/rev/47cb7a74ba07
https://hg.mozilla.org/mozilla-central/rev/f39c77b470b8
https://hg.mozilla.org/mozilla-central/rev/5b6e2a714cec
https://hg.mozilla.org/mozilla-central/rev/6fa404d3fde2
https://hg.mozilla.org/mozilla-central/rev/9bc9d14ce2df
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in
before you can comment on or make changes to this bug.
Description
•