Closed
Bug 1278133
Opened 8 years ago
Closed 8 years ago
Private tabs forget current page upon detach e10s
Categories
(Firefox :: Private Browsing, defect, P1)
Tracking
()
RESOLVED
DUPLICATE
of bug 1278664
Tracking | Status | |
---|---|---|
e10s | + | --- |
firefox48 | --- | unaffected |
firefox49 | + | verified |
People
(Reporter: bram.speeckaert, Assigned: jandreou25)
References
Details
(Keywords: dataloss, regression)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160605030215
Steps to reproduce:
0) Make sure e10s is enabled.
1) Open a private window and open at least two tabs.
2) Load a website in on of the tabs (e.g. https://html5zombo.com/).
3) Detach the website tab to spawn a new window.
Strangely this does not seem to happen with any of the about: pages (e.g. about:robots).
Actual results:
The new window does not retain the loaded page and instead shows a blank page.
Expected results:
The new window should retain the previously loaded page.
Updated•8 years ago
|
tracking-e10s:
--- → ?
Comment 1•8 years ago
|
||
[Tracking Requested - why for this release]:
Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=16b4946069a9470a94f33791de7440966844747d&tochange=ff298d2993a32aeaca0eacac32d8e673298cf5c5
Regressed by: ff298d2993a3 James Andreou — Bug 1269361 - Add mPrivateBrowsingId to OriginAttributes r=ehsan,jdm
Blocks: 1269361
Status: UNCONFIRMED → NEW
status-firefox48:
--- → unaffected
status-firefox49:
--- → affected
tracking-firefox49:
--- → ?
Component: Untriaged → Private Browsing
Ever confirmed: true
Flags: needinfo?(jandreou)
Keywords: regression
Assignee | ||
Comment 3•8 years ago
|
||
Assignee: nobody → jandreou
Attachment #8760838 -
Flags: review?(amarchesini)
Comment 4•8 years ago
|
||
Comment on attachment 8760838 [details] [diff] [review]
Bug1278133.patch
Review of attachment 8760838 [details] [diff] [review]:
-----------------------------------------------------------------
This makes sense to me, but smaug (or another docShell peer) should review it.
Attachment #8760838 -
Flags: review?(bugs)
Attachment #8760838 -
Flags: review?(amarchesini)
Attachment #8760838 -
Flags: feedback+
Comment 5•8 years ago
|
||
Comment on attachment 8760838 [details] [diff] [review]
Bug1278133.patch
I don't understand this. Why would the chrome docshell (mOwnerContent->OwnerDoc()->GetDocShell()) have private browsing flag set in its origin attributes. That looks like a bug to me if that is the case.
Attachment #8760838 -
Flags: review?(bugs) → review-
Updated•8 years ago
|
Assignee | ||
Comment 7•8 years ago
|
||
Smaug is correct that currently chrome docshells have a private browsing origin attribute. I created Bug 1278664 to address this issue.
Assignee | ||
Comment 8•8 years ago
|
||
Using the privatebrowsingflag in docshell will still work after removing privateBrowsingId from chrome docshells.
Attachment #8760838 -
Attachment is obsolete: true
Attachment #8760891 -
Flags: review?(bugs)
Comment 9•8 years ago
|
||
Comment on attachment 8760891 [details] [diff] [review]
Bug1278133.patch
>+ nsresult rv = parentContext->GetUsePrivateBrowsing(&isPrivate);
>+ NS_ENSURE_SUCCESS(rv, rv);
nsILoadContext has a C++ helper for getting the flag, so you could just
bool isPrivate = parentContext->UsePrivateBrowsing();
So this is fine to fix this regression, but
why doesn't the ownercontent have mozprivatebrowsing attribute? Bug in tabbrowser.xml?
Attachment #8760891 -
Flags: review?(bugs) → review+
Comment 10•8 years ago
|
||
(In reply to :Ehsan Akhgari (busy, don't ask for review please) from comment #6)
> This is an e10s regression, should definitely be tracked.
This is a regression in 49, and should be tracked by that release through relman.
Priority: -- → P1
Assignee | ||
Comment 11•8 years ago
|
||
Attachment #8760891 -
Attachment is obsolete: true
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 12•8 years ago
|
||
Isn't this more or less the same patch from bug 1278664, which just landed on central? If so, should we close this one out and clear the checkin-needed?
Flags: needinfo?(jandreou)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jandreou)
Keywords: checkin-needed
Assignee | ||
Comment 13•8 years ago
|
||
This patch was landed in bug 1278664.
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 15•8 years ago
|
||
(In reply to Mike Conley (:mconley) - (needinfo me!) from comment #14)
> Do we think this fix warrants uplift to aurora?
Yes. James, can you please nominate? Thanks!
Flags: needinfo?(ehsan) → needinfo?(jandreou)
Assignee | ||
Comment 16•8 years ago
|
||
Comment on attachment 8761240 [details] [diff] [review]
Bug1278133.patch
Approval Request Comment
[Feature/regressing bug #]: 1269361
[User impact if declined]:
Users would be unable to drag a tab into a new window while using private browsing and e10s.
[Describe test coverage new/current, TreeHerder]:
This was manually tested.
[Risks and why]:
Self contained bug, very low risk of causing more regressions.
[String/UUID change made/needed]:
None.
Flags: needinfo?(jandreou)
Attachment #8761240 -
Flags: approval-mozilla-aurora?
Recent regression, tracking.
Comment on attachment 8761240 [details] [diff] [review]
Bug1278133.patch
Important to have tabs work, let's uplift to aurora.
We should verify the fix in aurora once it lands.
Attachment #8761240 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: qe-verify+
Comment 20•8 years ago
|
||
in bug 1278664 2 patches landed, which does need uplift, both ?
Flags: needinfo?(jandreou)
Assignee | ||
Comment 21•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3fb62649e99a should fix the regression alone.
Flags: needinfo?(jandreou)
Comment 22•8 years ago
|
||
Comment 23•8 years ago
|
||
I reproduced this bug using Fx 49.0a1 build ID:20160605030215, on Windows 10 x64.
I can confirm the fix on Fx 49.0a2, build ID 20160701004039 on Windows 10 x64, Ubuntu 16.04 LTS and Mac OSX 10.9.5 .
Updated•8 years ago
|
Status: VERIFIED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: FIXED → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•