Remove preprocessing from preferences .js files by converting to AppConstants.jsm

Try run: https://hg.mozilla.org/try-comm-central/rev/b9d0418d43d8bedbe589ef36750aa697c4f9feb7

Comment on attachment 8760464 [details] [diff] [review] patch Review of attachment 8760464 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/preferences/advanced.js @@ +77,5 @@ > + checkElem.checked = false; > + } > + checkElem = document.getElementById("checkDefaultButton"); > + if (checkElem) > + checkElem.disabled = true; Good with the added comment, but document.getElementById is really fast enough that the old code is better as it's more readable @@ +208,5 @@ > */ > updateReadPrefs: function () > { > + if (!AppConstants.MOZ_UPDATER) > + return; unneeded, no? @@ +255,5 @@ > */ > updateWritePrefs: function () > { > + if (!AppConstants.MOZ_UPDATER) > + return; and here @@ +278,5 @@ > > showUpdates: function () > { > + if (!AppConstants.MOZ_UPDATER) > + return; and here

(In reply to Magnus Melin from comment #2) > @@ +208,5 @@ > > */ > > updateReadPrefs: function () > > { > > + if (!AppConstants.MOZ_UPDATER) > > + return; > > unneeded, no? Safety and preserving semantics :) With the preprocessing the functions wouldn't even exist. So now at least make them do nothing so that nobody calls them by mistake. And if he does, no harm happens. Should I remove it?

Well they are available now, not just called. Anyway, I think it's unnecessary to have those checks

OK.

https://hg.mozilla.org/comm-central/rev/c37795888b0e9e92bbb145403b72bf14a201285e Bug 1278337 - remove preprocessing from preferences .js files by converting to AppConstants.jsm. r=mkmelin