Brian Grinstead [:bgrins] Assignee
	Description • 8 years ago

There's a discussion here with the intent to remove: https://lists.mozilla.org/pipermail/dev-platform/2016-June/015317.html.

Folder: toolkit/components/console/
Pref: devtools.errorconsole.enabled

	Brian Grinstead [:bgrins] Assignee
	Comment 1 • 8 years ago

Review commit: https://reviewboard.mozilla.org/r/58344/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/58344/

	Brian Grinstead [:bgrins] Assignee
	Comment 2 • 8 years ago

Going to give Bug 1243550 a bit of time before landing this.  Here's a tentative try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a48f77e47e8

	Brian Grinstead [:bgrins] Assignee
	Comment 3 • 8 years ago

Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58344/diff/1-2/

	Brian Grinstead [:bgrins] Assignee
	Comment 4 • 8 years ago

Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58344/diff/2-3/

	Brian Grinstead [:bgrins] Assignee
	Comment 5 • 8 years ago

https://reviewboard.mozilla.org/r/58344/#review57122

::: browser/base/content/test/general/browser.ini
(Diff revision 3)
>  [browser_bug559991.js]
>  [browser_bug561636.js]
>  skip-if = true # bug 1057615
>  [browser_bug563588.js]
>  [browser_bug565575.js]
> -[browser_bug565667.js]

I tried to port this test to use a different URL instead of console.xul but couldn't get it working locally.  I'm not sure (a) if the thing it's testing was only relevant for the console and if not then (b) if there's another xul file we could load in the test to get a similar effect

	Justin Dolske [:Dolske]
	Comment 6 • 8 years ago

Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

https://reviewboard.mozilla.org/r/58344/#review57326

ding-dong, it's dead.

One small comment on a test, not a requirement to fix.

::: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_nonbrowser.js:18
(Diff revision 3)
>    });
>  
>    let win = OpenBrowserWindow({private: true});
>    win.addEventListener("load", function onLoad() {
>      win.removeEventListener("load", onLoad, false);
> -    let consoleWin = win.open("chrome://global/content/console.xul", "_blank", "chrome,extrachrome,menubar,resizable,scrollbars,status,toolbar");
> +    let chromeWin = win.open("chrome://browser/content/preferences/permissions.xul", "_blank", "chrome,extrachrome,menubar,resizable,scrollbars,status,toolbar");

This is probably fine, but I twich a little about opening permissions.xul in an unexpected way.

win.open("about:blank") doesn't seem to open anything (disappointing!), but maybe places.xul would be better than permissions.xul? Realistic, too.

	Brian Grinstead [:bgrins] Assignee
	Comment 7 • 8 years ago

Comment on attachment 8760948 [details]
Bug 1278368 - Remove the error console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/58344/diff/3-4/

	Brian Grinstead [:bgrins] Assignee
	Comment 8 • 8 years ago

Let's try with places.xul and see what happens: https://treeherder.mozilla.org/#/jobs?repo=try&revision=17daf8ca1433

	Justin Dolske [:Dolske]
	Comment 9 • 8 years ago

(In reply to Justin Dolske [:Dolske] from comment #6)

> win.open("about:blank") doesn't seem to open anything (disappointing!)

Oh, ha, actually this does work. I just noticed I have some tiny 16x32 windows on my desktop, which I didn't notice before. They're adorbs.

	Brian Grinstead [:bgrins] Assignee
	Comment 10 • 8 years ago

Lots of orange on the push but it doesn't look like it's any of the tests touched here

	Pulsebot
	Comment 11 • 8 years ago

Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/bb34ab2ea11b
Remove the error console. r=dolske

	Phil Ringnalda (:philor)
	Comment 12 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/bb34ab2ea11b