Closed Bug 1278577 Opened 8 years ago Closed 8 years ago

RefTest structured log ids should be strings not arrays

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(firefox50 fixed)

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: jgraham, Unassigned)

References

Details

Attachments

(1 file)

Although the original idea with structured logging was that the test ids could be tuples, it turns out that downstream consumers often don't work well with a string|tuple datatype e.g. it doesn't work well with a database. So we should stick to using pure-string identifiers.
The idea of mozlog ids being tuples unfortunately didn't work so well with external systems that found the tuple|string datatype difficult to work with. Convert reftests to use simple ids of the form "<test url> <comparison> <refurl>" e.g. "about:blank == data:text/html," instead of tuples. Review commit: https://reviewboard.mozilla.org/r/58238/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58238/
Attachment #8760822 - Flags: review?(ahalberstadt)
Comment on attachment 8760822 [details] Bug 1278577 - Use simple strings as reftest test ids, https://reviewboard.mozilla.org/r/58238/#review55150 Thanks, lgtm!
Attachment #8760822 - Flags: review?(ahalberstadt) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: