Closed
Bug 1278636
Opened 8 years ago
Closed 8 years ago
Disable predictor prefetch on aurora 49
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla49
People
(Reporter: u408661, Assigned: u408661)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
(deleted),
patch
|
mayhemer
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1268208 +++
Some regressions from bug 1016628 have still not been fixed. Let's disable on aurora again.
Attachment #8760860 -
Flags: review?(honzab.moz)
Updated•8 years ago
|
Attachment #8760860 -
Flags: review?(honzab.moz) → review+
Comment on attachment 8760860 [details] [diff] [review]
disable-prefetch.patch
Approval Request Comment
[Feature/regressing bug #]: 1016628
[User impact if declined]: known regressions
[Describe test coverage new/current, TreeHerder]: on beta (previously aurora)
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8760860 -
Flags: approval-mozilla-aurora?
Is this enabled on beta 48 and aurora 49? I want to make sure we're disabling it in the correct versions since this request was just after the merge.
status-firefox48:
--- → ?
status-firefox49:
--- → ?
tracking-firefox49:
--- → ?
Flags: needinfo?(hurley)
No, this is only enabled on aurora 49. It was disabled for 48 back when that was aurora (bug 1268208).
I plan on landing a patch to ifdef the pref on m-c so we don't have to keep doing this dance every merge until I get the issues fixed (though hopefully that will be by the time 50 becomes aurora).
Thanks, yes probably ifdef is the way to go here until you are sure.
tracking-firefox49:
? → ---
Comment on attachment 8760860 [details] [diff] [review]
disable-prefetch.patch
Feature not ready, preffing it off for aurora 49. Please uplift.
Attachment #8760860 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•8 years ago
|
||
Comment 8•8 years ago
|
||
So closing as fixed.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment 9•8 years ago
|
||
and the perf wins from this:
https://treeherder.mozilla.org/perf.html#/alerts?id=1583
Comment 10•8 years ago
|
||
as a note, it appears we have fixed the perf issues on trunk (v.50)
You need to log in
before you can comment on or make changes to this bug.
Description
•