It's currently possible to get working artifact builds on Try for linux64 via e.g., https://hg.mozilla.org/try/rev/5353c8f1e12cd91d5684b038f17ca3fdbe11c6b0 We'd like a similar ability for OSX and Windows artifact builds; chmanchester mentioned this might require a little work.

I can take start looking into this.

I have a patch set that gets these working on each of the platforms for opt builds. Debug builds are going to need bug 1279369 as well.

Review commit: https://reviewboard.mozilla.org/r/58912/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58912/

Review commit: https://reviewboard.mozilla.org/r/58914/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/58914/

Comment on attachment 8761877 [details] Bug 1278700 - Add missing libraries to Mac artifact builds to avoid failing in the packager when doing an artifact build on automation. https://reviewboard.mozilla.org/r/58912/#review56182

Comment on attachment 8761878 [details] Bug 1278700 - Skip checks and build steps causing artifact builds to fail in automation. https://reviewboard.mozilla.org/r/58914/#review56184 Looks good to me - just curious about a few of the details. ::: build/win32/moz.build:18 (Diff revision 1) > ] > USE_STATIC_LIBS = True > > NO_PGO = True > > -if CONFIG['WIN32_REDIST_DIR']: > +if CONFIG['WIN32_REDIST_DIR'] and CONFIG['COMPILE_ENVIRONMENT']: Do we get these DLLs from the package in artifact builds? I would think they'd still be necessary, but I realize they depend on CC_VERSION... ::: toolkit/mozapps/installer/upload-files.mk:486 (Diff revision 1) > $(call QUOTED_WILDCARD,$(UNIFY_DIST)/$(SDK_PATH)$(PKG_BASENAME)-$(UNIFY_ARCH).sdk$(SDK_SUFFIX).asc) > endif > > SIGN_CHECKSUM_CMD= > ifdef MOZ_SIGN_CMD > + ifdef COMPILE_ENVIRONMENT What actually fails here that we need the compile environment? The QUOTED_WILDCARD calls should just avoid adding the files if they don't exist. I guess something with the checksum generation?

https://reviewboard.mozilla.org/r/58914/#review56184 > Do we get these DLLs from the package in artifact builds? I would think they'd still be necessary, but I realize they depend on CC_VERSION... Double checking the log, we get them from the package. > What actually fails here that we need the compile environment? The QUOTED_WILDCARD calls should just avoid adding the files if they don't exist. I guess something with the checksum generation? As discussed irl, we're failing because MOZ_SIGN_CMD tries to find a file that doesn't exist: https://treeherder.mozilla.org/#/jobs?repo=try&revision=041ac342b24212bc56978b21bd235beff0c3ffa1&selectedJob=22210687 is an instance of this, which is odd, because enable_signing is set to false in that build, so it appears buildbot is setting MOZ_SIGN_CMD. It would be good to figure this out... let me know if something here rings a bell.

https://reviewboard.mozilla.org/r/58914/#review56184 > As discussed irl, we're failing because MOZ_SIGN_CMD tries to find a file that doesn't exist: https://treeherder.mozilla.org/#/jobs?repo=try&revision=041ac342b24212bc56978b21bd235beff0c3ffa1&selectedJob=22210687 is an instance of this, which is odd, because enable_signing is set to false in that build, so it appears buildbot is setting MOZ_SIGN_CMD. > > It would be good to figure this out... let me know if something here rings a bell. I tried this with enable_signing set to True in the mozharness config, and the command succeeded. I'm not sure what the significance of this is, but I'll leave this chunk out for now.

Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b70b95b46ae5 Add missing libraries to Mac artifact builds to avoid failing in the packager when doing an artifact build on automation. r=mshal https://hg.mozilla.org/integration/mozilla-inbound/rev/9ede51c42e03 Skip checks and build steps causing artifact builds to fail in automation. r=mshal

https://hg.mozilla.org/mozilla-central/rev/b70b95b46ae5 https://hg.mozilla.org/mozilla-central/rev/9ede51c42e03