Eddy Bruel [:ejpbruel] Assignee
	Description • 8 years ago

Our goal is to replace all uses of the old Actor/FrontClass constructors with the new Actor/FrontClassWithSpec constructors. We have several server tests that define their own actors for the purpose of that test, so these need to be decoupled as well.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 1 • 8 years ago

I did not move the actor specifications to the shared directory, because this seemed like overkill; we can keep the specs in the tests themselves, since the fronts are defined there as well. These fronts are not used anywhere else, and do not involve requiring any files from the client directory, so this should not pose any problems.

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 2 • 8 years ago

Great! I just started a WIP on this, but now I don't have to do it :)

	Eddy Bruel [:ejpbruel] Assignee
	Comment 3 • 8 years ago

Try run for this patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ede9e956c83

	Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]
	Comment 4 • 8 years ago

Gotta run `./mach eslint devtools` with these decoupling patches ;)

> TEST-UNEXPECTED-ERROR | devtools/shared/fronts/gcli.js:13:23 | Missing space before function parentheses. (space-before-function-paren)
> TEST-UNEXPECTED-ERROR | devtools/shared/fronts/gcli.js:31:36 | Missing space before function parentheses. (space-before-function-paren)

I assume this is from the gcli patch that this bug is working on top of.

	Eddy Bruel [:ejpbruel] Assignee
	Comment 5 • 8 years ago

(In reply to Nick Fitzgerald [:fitzgen] [⏰PDT; UTC-7] from comment #4)
> Gotta run `./mach eslint devtools` with these decoupling patches ;)
> 
> > TEST-UNEXPECTED-ERROR | devtools/shared/fronts/gcli.js:13:23 | Missing space before function parentheses. (space-before-function-paren)
> > TEST-UNEXPECTED-ERROR | devtools/shared/fronts/gcli.js:31:36 | Missing space before function parentheses. (space-before-function-paren)
> 
> I assume this is from the gcli patch that this bug is working on top of.

I did, and then only fixed devtools/shared/specs/gcli.js. I am not smart :-(

	Pulsebot
	Comment 6 • 8 years ago

Pushed by ejpbruel@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/e10403956d1e
Decouple the test actors;r=fitzgen

	Carsten Book [:Tomcat]
	Comment 7 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e10403956d1e

	Eddy Bruel [:ejpbruel] Assignee
	Comment 8 • 8 years ago

I accidentally pushed an empty patch on this bug.

	Pulsebot
	Comment 9 • 8 years ago

Pushed by ejpbruel@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/93a9cda876d8
Decouple the test actors;r=fitzgen

	Carsten Book [:Tomcat]
	Comment 10 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/93a9cda876d8