Closed
Bug 1278812
Opened 8 years ago
Closed 8 years ago
mach artifact install fails with "No such file or directory 'objdir-frontend/dist/bin/plugin-container'"
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox53 fixed)
VERIFIED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: johannh, Assigned: standard8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Full output https://pastebin.mozilla.org/8875802
tl;dr my mach build command (after clobber) fails to run because it can not find "objdir-frontend/dist/bin/plugin-container".
Reporter | ||
Updated•8 years ago
|
Updated•8 years ago
|
Blocks: e10s-rename
Comment 1•8 years ago
|
||
It's weird, but after trying to bisect the change that broke artifact builds I no longer get this error on fx-team tip (in the same cset where I used to get it).
Reporter | ||
Comment 2•8 years ago
|
||
Not getting this on fx-team anymore either. Should we close the bug?
Comment 3•8 years ago
|
||
I guess so. I wonder if it was a case where the downloaded artifacts weren't recent enough for the local build to pass.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Comment 4•8 years ago
|
||
For reference, the patch that recently landed for bug 1114647 didn't change the set of installed files, so in theory it shouldn't have caused this. (An earlier attempt in April — bug 1114647 comment #59 through 75 — did rename plugin-container but was backed out.)
Comment 5•8 years ago
|
||
I hit this again today.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Reporter | ||
Comment 6•8 years ago
|
||
Yeah me too on the latest central (f8e3b81a79f4)
Comment 7•8 years ago
|
||
It is interesting that in the objdir there is this empty directory: dist/bin/plugin-container.app/Contents/MacOS/
Reporter | ||
Comment 8•8 years ago
|
||
Hit this again today on central and inbound.
Comment 9•8 years ago
|
||
My colleague aswan and I are both seeing this today with artifact builds on OS X. They fail with this same error message.
Comment 10•8 years ago
|
||
The timing sounds like it may be related to bug 1295375.
However, `hg bisect` says it is from https://hg.mozilla.org/mozilla-central/rev/88e0fb654a10. This is almost certainly because that was a push head for the mozilla-central push/merge where universal os x builds were dropped.
Depends on: 1295375
Comment 11•8 years ago
|
||
What branch+revision is the artifact build grabbing? I took a quick look at a random package before and after the universal build change and both have the same paths for plugin-container, so I'm not sure why this would start failing now.
Assignee | ||
Comment 12•8 years ago
|
||
I took a look and here's what is happening.
According to artifacts.py, it is looking for a 'public/build/firefox-(.*).mac.dmg' on taskcluster. However, taskcluster is now listing the opt builds as 'mac64' not 'mac':
https://tools.taskcluster.net/index/artifacts/#gecko.v2.mozilla-central.latest.firefox/gecko.v2.mozilla-central.latest.firefox.macosx64-opt
Looking at http://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central/, we can also see that the nightly builds have changed from 'mac' to 'mac64' (there's both sets in there currently).
I'm guessing that change is wrong and is going to upset everyone.
Due to the switch away from universal binaries, we're now hitting the else part of the ifdef here:
https://dxr.mozilla.org/mozilla-central/rev/8103c612b79c2587ea4ca1b0a9f9f82db4b185b8/toolkit/mozapps/installer/package-name.mk#33
I think the simple solution is just to update that ifdef. I'll get a patch up in a few.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•8 years ago
|
||
My local builds & the try builds appear to be ok with this change.
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8818223 [details]
Bug 1278812 - Change default mac filename to be 'mac' rather than 'mac64' now that bug 1295375 has moved us away from universal builds.
https://reviewboard.mozilla.org/r/98370/#review98610
Good catch.
This does mean we'll be unable to find artifacts across TC index renames. But this should be rare, so hopefully we can ignore this edge case.
Also, the `package-name.mk` should have ideally been split to its own commits, as it has more to do with cleaning up recently-unused code. But meh. Happy to see all references to the old platform name nuked.
Attachment #8818223 -
Flags: review?(gps) → review+
Comment 16•8 years ago
|
||
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5436f5de7305
Change default mac filename to be 'mac' rather than 'mac64' now that bug 1295375 has moved us away from universal builds. r=gps
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → standard8
Comment 17•8 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 18•8 years ago
|
||
I can confirm that this fixes the issue for me. Thanks for the fix.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•