Closed
Bug 1279641
Opened 8 years ago
Closed 8 years ago
[css-grid] 'span' is an invalid <custom-ident> in line name lists
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla50
Tracking | Status | |
---|---|---|
firefox50 | --- | fixed |
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
We currently reject 'span' as a <custom-ident> only in grid-row/column.
We should reject it in all line name lists too.
https://drafts.csswg.org/css-grid/#typedef-line-names
https://lists.w3.org/Archives/Public/www-style/2016Jun/0031.html
https://drafts.csswg.org/css-values-3/#identifier-value
(It /appears/ all names are valid in 'grid-template-areas' though:
https://drafts.csswg.org/css-grid/#grid-template-areas-property
since they are just strings with no additional restrictions, AFAICT.
So, grid-template-areas:"inherit"; is a valid declaration, and
grid-row:inherit-end; would match that area's end edge.)
Updated•8 years ago
|
Summary: [css-grid] 'span' is an invalid <cutstom-ident> in line name lists → [css-grid] 'span' is an invalid <custom-ident> in line name lists
Comment 1•8 years ago
|
||
If you haven't already started working on this, would it be all right if I co-opt this as a "good first bug" for an intern who starts in 2 weeks?
(I could find another one as well; just pouncing on this one, since it fits the desired "good-first-bug" criteria of being a relatively small layout/style-system change, which affects behavior & is testable.)
Flags: needinfo?(mats)
Assignee | ||
Comment 2•8 years ago
|
||
Sorry, I already wrote the patch. It's a one-liner so probably a little bit
too easy for an intern anyway.
Flags: needinfo?(mats)
Comment 3•8 years ago
|
||
Fair enough, no worries. (Let me know if you come across any other similarly-simple+testable changes that we need to make, which I can co-opt for an intern.)
Assignee | ||
Comment 4•8 years ago
|
||
I fixed a few of the existing invalid values in the test as well.
I think we forgot to updated these when we switched from () to []
in the line name list syntax.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=603bf6d664f22c084dcd022aae3e2a374a9e783c
Attachment #8762276 -
Flags: review?(dholbert)
Updated•8 years ago
|
Attachment #8762276 -
Flags: review?(dholbert) → review+
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de7c0a103182
[css-grid] Make 'span' an invalid <custom-ident> in line name lists. r=dholbert
Assignee | ||
Updated•8 years ago
|
Flags: in-testsuite+
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Updated•8 years ago
|
Keywords: dev-doc-needed
Comment 7•8 years ago
|
||
Updated:
https://developer.mozilla.org/en-US/docs/Web/CSS/custom-ident
and
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-row-start
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-row-end
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-column-start
https://developer.mozilla.org/en-US/docs/Web/CSS/grid-column-end
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•