Closed
Bug 1279649
Opened 8 years ago
Closed 8 years ago
The inspector-pane-toggle should be rotated 90 deg, when docking to side of browser and vertical mode
Categories
(DevTools :: Inspector, defect, P1)
DevTools
Inspector
Tracking
(firefox49 verified, firefox50 verified)
People
(Reporter: magicp.jp, Assigned: Honza)
References
Details
(Whiteboard: [devtools-html])
Attachments
(2 files)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
ntim
:
review+
lizzard
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160610073607
Steps to reproduce:
1. Start Nightly
2. Go to any sites (e.g. about:home)
3. Open DevTools > Inspector
4. Dock to side of browser window
5. Narrow toolbox-container untill vertical mode
Actual results:
Collapse/Expand pane button is not vertical mode. This is a regression of Bug 1189492.
Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=3a87296fe4145138c2ce15512bb31f76fe869cb4&tochange=42fab251fe111d5f891c9bde0ee1fb6f7f946a50
Expected results:
Collapse/Expand pane button should be vertical mode.
Blocks: 1266419
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox49:
--- → affected
status-firefox50:
--- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Updated•8 years ago
|
Blocks: devtools-html-2
Whiteboard: [devtools-html] [triage]
Updated•8 years ago
|
Flags: needinfo?(odvarko)
Comment 1•8 years ago
|
||
https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/inspector.css#92
> .toolbarbutton-icon should be changed to ::before
Comment 2•8 years ago
|
||
Nice catch magicjp btw, thanks for filing!
Updated•8 years ago
|
Flags: qe-verify+
QA Contact: alexandra.lucinet
Whiteboard: [devtools-html] [triage] → [devtools-html]
Updated•8 years ago
|
Priority: -- → P2
Updated•8 years ago
|
Assignee: nobody → odvarko
Status: NEW → ASSIGNED
Iteration: --- → 50.2
Priority: P2 → P1
Assignee | ||
Comment 3•8 years ago
|
||
Thanks for the report and analyses!
Patch attached.
Honza
Flags: needinfo?(odvarko)
Attachment #8764276 -
Flags: review?(ntim.bugs)
Updated•8 years ago
|
Attachment #8764276 -
Flags: review?(ntim.bugs) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/3724c3955693
Rotate inspector-pane-toggle 90 deg for vertical mode. r=ntim
Keywords: checkin-needed
Comment 6•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 50
Comment 7•8 years ago
|
||
Comment on attachment 8764276 [details] [diff] [review]
bug1279649.patch
Approval Request Comment
[Feature/regressing bug #]: Bug 1266419
[User impact if declined]: Inspector pane button is rotated the wrong way round when the sidebar is the displayed under the main panel
[Describe test coverage new/current, TreeHerder]: in Nightly
[Risks and why]: Low, 1 line CSS fix
[String/UUID change made/needed]: no
Attachment #8764276 -
Flags: approval-mozilla-aurora?
Comment on attachment 8764276 [details] [diff] [review]
bug1279649.patch
Regression from 49, fix looks simple, please uplift
Attachment #8764276 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
Comment 10•8 years ago
|
||
Reproduced with 50.0a1 from 2016-06-10 under Windows 10 64-bit.
Verified fixed with latest Aurora 49.0a2 and Nightly 50.0a1, across platforms [1].
[1] Windows 10 64-bit, Ubuntu 16.04 64-bit and Mac OS X 10.11.1
Status: RESOLVED → VERIFIED
QA Whiteboard: [qe-dthtml]
Flags: qe-verify+
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•