Closed Bug 1279682 Opened 8 years ago Closed 8 years ago

New find doesn't identify the correct locations of search terms

Categories

(Toolkit :: Find Toolbar, defect)

50 Branch
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- verified

People

(Reporter: bj, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

The new find toolbar (bug 384458) is very confused about where the text is located on the page. The holes in the dimming effect are incorrectly positioned. See the attached screen shot
Blocks: 384458
I can reproduce this issue on https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error, if I search for "throw". I've also noticed another issue on that page, I will file a separate bug.
This might be related to bug 1279697 (not all of pages are dimmed).
I've noticed another issue which might be related to this issue. Sometimes when I click the Next or Previous button the page isn't scrolled enough to put the newly selected text on the screen. I've reproduced it several times, but 1) only on pages full of sensitive data I don't want to make a screen shot of, and 2) only on pages where the search term locations are not correctly identified.
[Tracking Requested - why for this release]: Regression
Version: Trunk → 50 Branch
Depends on: 1279742
¡Hola B.J.! Steps: - Load https://www.ibm.com/support/knowledgecenter/SSAW57_8.5.5/com.ibm.websphere.messages.doc/com.ibm.ws.ssl.channel.resources.sslchannelmessages.html - Search (<Ctrl>+<F>) for "SSLC0008E" Result: Weird things happen, see http://i.imgur.com/xFiQebH.png Expected result: It works. Is this the bug you describe on https://bugzilla.mozilla.org/show_bug.cgi?id=1279682 or a new one? ¡Gracias! Alex
Flags: needinfo?(bj)
The problem on ibm.com seems to be a separate issue, but it's hard to tell without looking at the code. From looking at the image, the correct location is known (from the blue shading) but it also isn't know (from the yellow markings). I was able to reproduce that state by clicking the find next/find previous/highlight all buttons randomly.
Flags: needinfo?(bj)
Attached image findbar mozilla.png (deleted) —
User Agent:Mozilla/5.0 (Windows NT 6.1; rv:50.0) Gecko/20100101 Firefox/50.0 Build ID: 20160630030207 Also,on a page with vertical text, when search for all,highlighted text is not completely visible.
Feature has been backed out so not tracking these bugs for 50.
Bulk update to find bar bugs that won't be in 50 (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1279695#c4 and local testing).
This was fixed by bug 1279695.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
I can confirm that the issue from the Description of this bug is no longer reproducible - the position of the searched terms is correctly identified by the new find bar. What I observed while verifying this issue is that the position of the searched and highlighted terms is modified when minimizing/maximizing the browser (logged Bug 1302749 to cover this scenario). Another observed issue is that the scenario from Comment 8 is still reproducing (found Bug 1279715 to cover this other scenario). Based on the above, marking this as Verified.
Status: RESOLVED → VERIFIED
But see 1302386 for more a recent example of badly placed highlighting.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: