When switching between portrait and landscape orientation, a frames page disappears, but the frame dividers stay in place. Also, I've seen it render the NOFRAMES content on the second page in plaintext HTML. 2002022503/WinXP

Needs more investigation.

1) Added a new method to nsIWebBrowserPrint iface that enables you to get the current PS being used to print or PP 2) Change the PP toolbar code to use the current PS instead of the global

Comment on attachment 72618 [details] [diff] [review] patch r=dcone

r=law on the printPreviewBindings.xml portion.

Comment on attachment 72618 [details] [diff] [review] patch sr=attinasi

Comment on attachment 72618 [details] [diff] [review] patch a=asa (on behalf of drivers) for checkin to the 1.0 trunk

fixed

aaron, can you verify this is fixed for you now? let us know..thanks

Nope, sorry, I still see this with build 2002031008/WinXP on all frames pages.

See what? I see that framesets are not working in Landscape but I do not see the switching back to portrait once it is in landscape and you hit scale.

The reason the sub-docs don't show up in landscape is that for some reason PP is being called a second time (when in landscape) but not when in Portrait, this second call is a new bug. When in Portrait, if you hit the scale button or change a PrintSetting to cause an additional change to the PP the sub-docs dissappear, this is caused by Bug 108509 and will soon be fixed by moving the loading of sub-docs to content (a jst bug). So, if when viewing a doc in PP in landscape mode and you hit the scale button, if it stays in lanscape then please close this bug. This works for me.

All I do is hit the Landscape button (being in portrait mode) and everything breaks. Just as I originally reported.

sujay, Are you seeing this on a page without framesets?

Rod, for frames, there is definitely a problem as the reporter originaly states. I get the same result the reporter gets using his test page. For a non-frame site(abcnews.com), I can switch back and forth between landscape and portrait mode w/o problems. I'm using 3/12 trunk commercial build on win 98

Ok, so I fixed a different problem with my previous check in for this bug. This is Frameset issue as I stated in comment #11 AND the fact that it gets asked to PP twice. I will make this dependent on Bug 109509, which when jst checks in his content/sub-docs fix, this should be fixed.

This depends on bug 52334 not 108509

adt3 per adt triage

I am dup'ing this to Bug 122048 because the patch in that bug fixes this bug also. This bug will also be fixed when Bug 52334 gets checked in. So we are well covered and I want to take this off the radar. *** This bug has been marked as a duplicate of 122048 ***

verified...this is fixed now in today's 3/27 build.

Filed bug 133808 and bug 133809 to hit on some related issues.