Closed
Bug 1279805
Opened 8 years ago
Closed 8 years ago
Add UTM information to the "What's new?" link in the about dialog
Categories
(Firefox :: Menus, defect, P3)
Firefox
Menus
Tracking
()
RESOLVED
FIXED
Firefox 55
People
(Reporter: Sylvestre, Assigned: MattN, Mentored)
References
Details
(Whiteboard: [good first bug])
Attachments
(2 files, 2 obsolete files)
In bug 1047395, we added a link to the release notes from the about dialog, we should add some trackers to have an idea of the usage of this link.
This should probably be added here:
https://dxr.mozilla.org/mozilla-central/source/browser/base/content/aboutDialog.xul#50
We might create a new link in firefox.js
Hi Sylvestre!
I am a first time contributor to Mozilla and Id like to work on this bug.
How do I get this working on my local machine? Do I need to setup/build? Is there a github repo I can pull from to get the code?
Also, if you could give a little more detail about the bug and how to approach it I think that will be really helpful.
Really excited to get my 1st Mozilla ticket!
Let me know!
Cheers!
Comment 2•8 years ago
|
||
Hello dindrala,
I have already started on this.
Here's the info for getting started with the repo & workflow, whether you're using git or hg: https://developer.mozilla.org/en-US/docs/Mozilla/Git
Regards,
Paul
Hey Paul,
Apologies! The ticket says and still does say it isn't assigned to anyone.
Thank you for the work flow information.
Cheers!
Updated•8 years ago
|
Flags: needinfo?(gavin.sharp)
Flags: needinfo?(garethcull.bugs)
Comment 4•8 years ago
|
||
Attachment #8763498 -
Flags: review?(garethcull.bugs)
Comment 5•8 years ago
|
||
Hello Gareth,
What do you think about my proposal? I wans't sure what to put into utm_campaign.
Sylvestre, could you please specify what you would like in firefox.js? I don't know which pref value to set.
Regards,
Paul
Flags: needinfo?(garethcull.bugs)
Updated•8 years ago
|
Flags: needinfo?(gavin.sharp)
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → paul.bignier
Updated•8 years ago
|
Priority: -- → P3
Reporter | ||
Comment 6•8 years ago
|
||
Comment on attachment 8763498 [details] [diff] [review]
0001-Bug-1279805-fixed-Add-UTM-info-to-the-What-s-new-lin.patch
Chris, can you help with that? Or could you redirect to a better person if needed? Thanks
Attachment #8763498 -
Flags: review?(chrismore.bugzilla)
Comment 7•8 years ago
|
||
Hey Guys,
If you want to add utm parameters to whatsnew when it loads, can you please append the following:
?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=whatsnew
Gareth
Comment 8•8 years ago
|
||
> If you want to add utm parameters to whatsnew when it loads, can you please append the following
Done, thank you for the tip!
Attachment #8763498 -
Attachment is obsolete: true
Attachment #8763498 -
Flags: review?(garethcull.bugs)
Attachment #8763498 -
Flags: review?(chrismore.bugzilla)
Attachment #8775582 -
Flags: review?(garethcull.bugs)
Reporter | ||
Comment 9•8 years ago
|
||
Chris, can you help with this? Thanks
Flags: needinfo?(chrismore.bugzilla)
Comment 10•8 years ago
|
||
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Chris, can you help with this? Thanks
Sure! What do you need me to me to do? :)
Flags: needinfo?(chrismore.bugzilla)
Updated•8 years ago
|
Attachment #8775582 -
Flags: review?(chrismore.bugzilla)
Comment 11•8 years ago
|
||
:garethc: can you help here with UTM parameters? We'll probably want to make sure stick with similar UTM parameters we use within the product.
Flags: needinfo?(garethcull.bugs)
Updated•8 years ago
|
Attachment #8775582 -
Flags: review?(chrismore.bugzilla)
Assignee | ||
Comment 12•8 years ago
|
||
Comment on attachment 8775582 [details] [diff] [review]
0001-Bug-1279805-fixed-Add-UTM-info-to-the-What-s-new-lin.patch
Review of attachment 8775582 [details] [diff] [review]:
-----------------------------------------------------------------
Hi Paul,
I'll steal this review since I don't think Gareth is the right person anyways. While your patch is correct, the approach from bug 1047395 was wrong IMO as it didn't take the advice in bug 1047395 comment 1 and so we're currently hard-coding this Mozilla URL unofficial/third-party builds. Since that's not your fault I'll just make a patch to fix this properly.
Attachment #8775582 -
Flags: review?(garethcull.bugs)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8775582 -
Attachment is obsolete: true
Flags: needinfo?(garethcull.bugs)
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8856737 [details]
Bug 1279805 - Use app.releaseNotesURL to control release notes in the about dialog.
https://reviewboard.mozilla.org/r/128654/#review131324
Attachment #8856737 -
Flags: review?(florian) → review+
Comment 16•8 years ago
|
||
mozreview-review |
Comment on attachment 8856738 [details]
Bug 1279805 - Add UTM information to the release notes link from the browser.
https://reviewboard.mozilla.org/r/128656/#review131326
Attachment #8856738 -
Flags: review?(florian) → review+
Comment 18•8 years ago
|
||
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/b34015dd0554
Use app.releaseNotesURL to control release notes in the about dialog. r=florian
https://hg.mozilla.org/integration/autoland/rev/e7efcfe485de
Add UTM information to the release notes link from the browser. r=florian
Comment 19•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b34015dd0554
https://hg.mozilla.org/mozilla-central/rev/e7efcfe485de
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•